phpBB 4 Bugs - Iconify Icons

[GTi]

Greetings All

I know that usually any bug should be reported to the bug tracker, however since phpBB 4 is still in development I thought it would be better to mention the icon bugs here because there is a chance that Hanakin may already know about the bugs but just hasn't finished working on the icons yet.

There is also the possibility that something could be an intentional change so it's not worth wasting our times opening a bug report without knowing if it is a bug or not.

I will place the bugs on new posts in this topic so that there is no confusion.

[GTi]

Bug 1

Usual Behaviour:
When you post a new topic or reply to a topic, a little red star will appear in the topic icon at the side of that topic in the topic list.
The star is to let you know that you have posted in that topic.

Bug description:
With phpBB 4, that red icon only appears on topics that you have started.

Templates affected:
viewforum_body.html
ucp_main_bookmarks.html
ucp_main_front.html
ucp_main_subscribed.html

Snippet from view forum template:

Code: Select all

{% if lang(topicrow.TOPIC_AUTHOR) == S_USERNAME %}
<span class="row-item-link-mine"></span>
{% endif%}

Bug cause:
{% if lang(topicrow.TOPIC_AUTHOR) == S_USERNAME %}

Replacement:
{% if topicrow.S_USER_POSTED %}

I have tested the replacement snippet and can confirm it restores the usual behaviour as described above.


Additional Info:
The original snippet also appears in 1 other template which is mcp_forum.html but my replacement snippet does not work in that template.

With that said, this icon does not appear on the MCP forum page in phpBB 3 anyway - I believe it was supposed to as it would make life easier for a moderator on a busy forum but for whatever reason it hasn't been flagged.

[GTi]

Bug 2:

Usual Behaviour:
On the UCP front page, only global announcements are shown but the topic icon colour turns red when there are unread posts in them.

Bug description:
With phpBB 4, the icon is does not change to red when there are unread topics or posts in the global announcements.

Template affected:
ucp_main_front.html

Snippet from ucp front page template:

Code: Select all

{% if topicrow.S_UNREAD_TOPIC %} unread{% else %} read{% endif %}

Bug cause:
{% if topicrow.S_UNREAD_TOPIC %}

Replacement:
{% if topicrow.S_UNREAD %}

I have tested the replacement snippet and can confirm it restores the usual behaviour as described above.


Los mejores deseos x

[hanakin]

There are bound to be issues caused by the icon rework. It was massive and we could not catch them. Feel free to create tickets and prs to address them.