phpBB 3.2.10-RC2 released

[Paul]

No, we always use com to test rc releases before the actual release

[3Di]

No, we always use com to test rc releases before the actual release

As I said that's new to me, thanks.

[rxu]

wildcard searches aren't working as expected.

That could be subject to particular .com Sphinx config, as described like here http://sphinxsearch.com/docs/current.ht ... prefix-len
But can't bet

[welshpaul]

I use php 7.2.31 and i'm seeing the following php error when using an extension that makes use of the request class:

The each() function is deprecated

I believe it is caused by a line of code in the following file:
phpBB3/phpbb/request/type_cast_helper.php

More so this:

Code: Select all

list($default_key, $default_value) = each($default);

Fixed in 3.3.0 but not in 3.2.x:
https://github.com/phpbb/phpbb/pull/5798/files

I thought phpBB 3.2.x was compatible with php 7.0, 7.1 and 7.2 but not 7.3 and up?
https://github.com/phpbb/phpbb/pull/4624

[rxu]

welshpaul
Normally you shouldn't get deprecation warnings on production board because of the error reporting level used for phpBB:

Code: Select all

// Report all errors, except notices and deprecation messages
$level = E_ALL & ~E_NOTICE & ~E_DEPRECATED;
error_reporting($level);

Why are you getting it?

[welshpaul]

Why are you getting it?

I am seeing the error via an extension that reports to bugsnag via an api to debug another issue.

While I understand that the depreciated functions still exists and that these functions will not be available in future versions I just thought such issues had been updated alongside 3.3.0.

[rxu]

So it should be ok on production. Also despite the function is deprecated it works as expected, so in common it doesn't mean that 3.2 is not PHP 7.2 compatible.

[welshpaul]

Yea I should have phrased things better. I needed to resolve this though as the free tier offered by Bugsnag is limited to reporting X amount of errors and I kept going over that allowance due to these deprecated errors. Anyway, resolved this issue on my board.

[Talk19Zehn]

Hello, what is the reason <hr class = "divider" /> was deleted in this template: viewtopic_ body.html

HTML diff 3.2.9_to_3.2.10-RC1 (ff => 3.2.10-RC2, 3.3.1-RC1)

Code: Select all

 - <hr class = "divider" />
<! - EVENT viewtopic_body_postrow_post_after ->
<! - END postrow -> 

?

The demarcation was unique and correct and well suited for the visually impaired to create a separation (color-visible feature) between the contributions. In addition, decorative graphics, lines, etc. could be declared via the CSS and subsequently used at that position.

In my opinion, the element hr.divider in the Prosilver standard style was a particularly good separating feature for the definition of a delimitation between the posts.

My suggestion is to undo the removal: Inheriting the template (viewtopic_ body.html) changes designs that used this class.

Small abolition with a big impact ...

Regards

[3Di]

^^ BBcode code needs an edit to separate your statement.
(edit: somebody did it for you without leaving his mark )



There were good reasons: https://tracker.phpbb.com/browse/PHPBB3-16445

Also, no one forbids you to copy the viewtopic_ body.html file in your style and add your missing line and its CSS.
You don't necessarily have to inherit everything.