phpBB 3.2.1 RC1 released

[javiexin]

I think we overlooked the event already being part of a previous release and therefore didn't object to the renaming. That is something that can be undone to prevent potential issues for extension authors.

No, I don't think we overlooked this: the proposal for this change was done well before 3.2.0 was published, to an event that was new as of 3.1.11RC1, and the original proposer of the event was consulted. The problem is the six months from 3.2.0 to now. The discussion about the rename dates back to December, and was revisited later.

[janus]

hi,

Could you please indicate if existing 3.2.0 styles need to be updated for 3.2.1 ?

See https://gist.github.com/marc1706/008db6 ... 82f389f6fc

[david63]

hi,

Could you please indicate if existing 3.2.0 styles need to be updated for 3.2.1 ?

There is a topic on phpbb.com with the style changes

[Meis2M]

any estimate time for release final version?

[DavidIQ]

Hope there will be a fix then.

Well the "fix" would be for you to change your extension. BC breaks are exactly that and not an indication that the software has to somehow change.

[javiexin]

The only non-bc change in Metadata Mgr is the move of the output_metadata_to_template function to acp_extension, where it belongs. And yes, this affects your "upload" extension.

Interestingly, this is your change, javiexin: https://github.com/phpbb/phpbb/pull/4698.
Yes, it is not backwards-compatible as it renames and moves a public method used by Upload Extensions (this extension is mine and not their).

Hope there will be a fix then.

Yes, it is my change, that's why I knew it was not BC. And I will do whatever Marc and the devs tell me on this respect. However, in my view, this method is a pure "view" method, that does not belong in a "model" class such as Metada Manager.

About the Upload extension, my fault: being authored by "boardtools" i assumed it was from both you and ForumHulp.

But, from the "core" point of view, the Upload extension is a "replacement" of acp_extensions. Therefore, you should transpose any changes and improvement implemented info acp_extensions unless you want "Upload" to be behind. This is just one (more) of these changes. And there are some more you should/must implement.

-javiexin

PS: if I am not mistaken, 3.2.0 also had a BC break in this same method: before, the template object was part of the class, and after, it was a required parameter of the method.