PHPBB3-14740 BBCode still parses wrong

[neufke]

Hi all,

https://tracker.phpbb.com/browse/PHPBB3-14740

Marc wrote a fix for this and i am very grateful but testing now and rewriting some extensions and i am noticing that, again, new messages aren't parsed correctly when using quotes in BBCodes while the OLD bbcodes were parsed correctly.

Now, what's the best course of action? Is this simply another bug (@Marc, i haven't found a way to set the unverified fix to "not working correctly") or am i on a "wild goose chase" with my "quotes in a BBCode". Any thoughts would be highly appreciated...

[DavidIQ]

Try responding to the ticket. JoshyPHP is usually responsive to tickets that he's either watching or have to do with BBCode.

[neufke]

Thanx DavidIQ, will start with that.

Any thoughts on the quotes within the BBCodes itself?

[DavidIQ]

Actually it was JoshyPHP who authored the fix:
https://github.com/phpbb/phpbb/pull/4404

Marc simply merged it. I can imagine quotes being present in BBCodes and they're part of the "quote" BBCode so perhaps the fix just needs some more refining. The BBCode parser is relatively new so Joshy is the resident expert right now. You might also want to link back to this topic in your response.

[neufke]

Thank you for the extra feedback, will add it to the comment!

[JoshyPHP]

Now, what's the best course of action?

Edit the old posts and re-save them so they get reparsed. You may need to add a non-space character to the post to force the update.

There isn't an easy way to force a single post to get reparsed currently. If you have many of those you may try the command line reparser.

[neufke]

Now, what's the best course of action?

Edit the old posts and re-save them so they get reparsed. You may need to add a non-space character to the post to force the update.

There isn't an easy way to force a single post to get reparsed currently. If you have many of those you may try the command line reparser.

The OLD posts are working correctly and they got parsed correctly. It's new posts that aren't working and don't get parsed when they have a quote in the BBCode...

So

Code: Select all

[mod="neufke"]This is a modremark[/mod]

Doesn't get parsed

Code: Select all

[mod=neufke]This is a modremark[/mod]

This is...

But if i change the bbcode... i lose all old BBCodes, and it's not the only one we use.

[JoshyPHP]

I thought you were talking about posts submitted on 3.2 but before 3.2.0. Try posting your BBCode definition and the steps to reproduce that issue because I can't reproduce it on my test board.

[neufke]

Haven't changed anything since RC but found that in the DB the bbcode_guid and quites haven't been added/parsed...

Code: Select all

<t>[mod="neufke"]This is a modremark[/mod]</t>

And to be complete:

BBCode use:

Code: Select all

[mod="{TEXT1}"]{TEXT2}[/mod]

HTML Replacement:

Code: Select all

<div id="modremark">
	<div id="modremarkexclamation">!</div>
	<div>
		<div id="moderemarktitle">Moderatoropmerking {L_FROM}{L_COLON} {TEXT1} :</div>
		<div id="moderemarktext">{TEXT2}</div>
	</div>
</div>

[neufke]

I thought you were talking about posts submitted on 3.2 but before 3.2.0. Try posting your BBCode definition and the steps to reproduce that issue because I can't reproduce it on my test board.

I've installed a fresh 3.2.0. board, first post with same BBCode settings...