Prevent deletion of built-in permission roles

[skouat]

Hi all !

Although this is rare, admins can delete built-in permissions roles.
As some extension can use them during the installation process, if roles are no longer available, the extension installation failed.

[Senky]

Well, then check for permission existence in your migration

[kasimi]

I think the migrator should take care of this. If the role doesn't exist, the permission.permission_set operation should be skipped, without throwing an error. Admins who delete built-in roles should know that extension won't be able to set default permission values.

Either that, or don't allow deleting built-in roles in the first place.

[brunoais]

I'd go for: The admin can always delete any role he chooses to but he should get an extra warning if he is trying to delete a builtin role. If he still decides to delete it, then it was his conscious choice.