EVENT Bug: Jumpbox bug if you use EVENT overall_footer_content_after.html

[Dragosvr92]

If you add anything in the overall_footer_content_after EVENT, it gets overlayed on the Jumpbox in the user profile.

Example:
Create the overall_footer_content_after.html event.

Add:

Code: Select all

<div style="background-color:#553D3C;padding: 4px;">Testing</div>

The jumpbox code needs to be better placed. Not sure how though atm.

[hanakin]

The name of the event is wrong for where its located for one as its placed at the end of the body not the footer

[Dragosvr92]

I fixed it by using the if statements to hide from ucp, adm, etc pages. But It should be fixed though.
The jumpbox needs to be added after the user profile wrapper. Not before the navbar.

[hanakin]

@Dragosvr92 can you pls create a ticket and submit a pr for it?

[Dragosvr92]

I can create a ticket, but i am unsure on how to fix it. I only found a way around it, hiding the content on those pages.
https://tracker.phpbb.com/browse/PHPBB3-14881

[MattF]

The event is perfectly fine...and correct!

There are floated elements in the style. Your template event listener needs to clear floats. Just add class="clear" to your div.

[Dragosvr92]

Adding the clear class breaks the existing layout of your div and you need to add extra css code to get it back to normal.

People that add content in the event usually want it to show in the main page footer, less on these pages: Memberlist, The team, Viewing Profiles, Vieving Groups.

Seems odd/unusual that you need to do extensive tweaking because the Jumpbox is badly placed and overlaps on plain new contents.
But thats just me.......

[MattF]

Adding the clear class breaks the existing layout of your div and you need to add extra css code to get it back to normal.

People that add content in the event usually want it to show in the main page footer, less on these pages: Memberlist, The team, Viewing Profiles, Vieving Groups.

Seems odd/unusual that you need to do extensive tweaking because the Jumpbox is badly placed and overlaps on plain new contents.
But thats just me.......

Then use a clearing div before your content to break the floats. Works just fine:
<div class="clear"></div>

It's not odd/unusual to have to make your template event listener work. You are injecting new code into a style. You can't assume your own code will just work plug-n-play. You have to make your code work within the style, at the injection point. The template events are, afterall, still what you should consider part of the style and are thus required to do whatever needed to make them work with the style (and that applies to every style).

[hanakin]

the code is broken as well the jumpbox should be contained in the same div as the return link but its not. Its not consistently placed the same way throughout the theme. It all needs a wrapping div around it and separated out into its own partial similar to the action-bar

[Dragosvr92]

Thank you for the pullrequest Hanakin.
*Sticking my tongue at the VSE grumpycat*