New Style for phpBB 3.3 ?

[Louis7777]

This is actually closer to the implementation we would go with

Code: Select all

<a class="menu-item" href="#" title="Faq"">
    <svg class="icon">
        <use xlink:href="#faq"></use>
        <span class="hide-mobile">Faq</span>
    </svg>
</a>

Or even better, something like this:

Code: Select all

<svg class="icon" role="img" title="Faq">
        <use xlink:href="external.svg#icon-faq" />
</svg>

And an Internet Explorer fallback if you may:

Code: Select all

/MSIE|Trident/.test(navigator.userAgent) && document.addEventListener('DOMContentLoaded', function () {
  [].forEach.call(document.querySelectorAll('svg'), function (svg) {
    var use = svg.querySelector('use'); 

    if (use) {
      var object = document.createElement('object');
      object.data = use.getAttribute('xlink:href');
      object.className = svg.getAttribute('class');
      svg.parentNode.replaceChild(object, svg);
    }
  });
});

[hanakin]

no fallback is needed for IE... Also there is no difference in our code other than I provided a label

[Louis7777]

no fallback is needed for IE... Also there is no difference in our code other than I provided a label

http://caniuse.com/#feat=svg

It is needed if you want to use an external svg file rather than inlining the code.

That's the best way to do it. A single small .svg sprite, external, that will be cached.

[hanakin]

external svg are highly problematic still even with js. We will probably opt for head loaded which is way more less problematic and thats one or two less server requests

[Louis7777]

external svg are highly problematic still even with js. We will probably opt for head loaded which is way more less problematic and thats one or two less server requests

I don't see any other problem other than a couple with IE 9-11 ?

[hanakin]

all the browsers have inconsistencies with external use or at least when I was working on the imageset pr they did. Especially when you get into styling and altering them.

Plus as I said if you can internalize the code for the images to the html page then you are reducing the number of requests made and its actually not that much overhead in file size for the html files which benefit more from caching

[CarpCharacin]

Will subblue help create the new style?

[hanakin]

prosilver was created in 2007, and subblue has long moved on. This is a project the current team and any members of these forums will be contributing to

[CarpCharacin]

Prosilver had actually been in the making since 2004 https://www.phpbb.com/development/prosilver/. I really like prosilver. What colors will the new style be? I think that we should keep the info panel on the right side.

[mrgtb]

and subblue has long moved on.

Did subBlue also create SubSilver theme