PHPBB3-14527 Dataloss caused by link shortening (maybe)

[JoshyPHP]

Ideally you would post that as a new topic, as it is unrelated to this one.

[Joe User]

If the last two and a half pages of this thread realy are unrelated to this thread, then there should a moderator just split this thread. Seems better than having two threads on the same issue...

[Joe User]

Since there is no progress: https://tracker.phpbb.com/browse/PHPBB3-14527

@Devs: Stop implementing new features and fix this nasty showstopping bug first.


Start reading here https://area51.phpbb.com/phpBB/viewtopi ... 41#p288141

[DavidIQ]

If the last two and a half pages of this thread realy are unrelated to this thread, then there should a moderator just split this thread. Seems better than having two threads on the same issue...

I'll move the posts but you've posted links to posts that might no longer make sense so I leave that for you to fix.

[Joe User]

The dataloss is fixed now, thanks.

But there are some more problems with link parsing left unfixed.

[JoshyPHP]

What would those be?

[Joe User]

Links like ftps://www.phpbb.com/ are parsed wrong.

[JoshyPHP]

There's a config setting that governs which URL schemes are allowed. You can change it via CLI but I don't know how to change it otherwise. You'll need to purge your cache afterwards.

Code: Select all

./bin/phpbbcli.php config:set allowed_schemes_links "http,https,ftp,ftps"

[Joe User]

Fine, but the hardcoded

Code: Select all

.*www => http://www

is the real problem.
It should be restricted to

Code: Select all

(EOL|SPACE)www

instead of

Code: Select all

.*www

Even better, just remove this buggy hardcoding entirely.

[JoshyPHP]

You really need to get rid of that abrasive tone if you want people to read your comments.