phpBB 3.2.0-b2 released

[CHItA]

I wasn't aware that the development config files aren't distributed with the download packages. In this case you can download the file from github.

[3Di]

I wasn't aware that the development config files aren't distributed with the download packages. In this case you can download the file from github.

That's what I already did, the issue here is:
is it normal to do that for every user or do you think this is an issue that needs to be fixed and thus a bug report needs to be filed?

I feel it should be fixed. IMO.

[david63]

The majority of users do not need the development config so I would have to disagree that it should be included, but I would concede that the development config files should be more readily available.

[3Di]

The majority of users do not need the development config so I would have to disagree that it should be included, but I would concede that the development config files should be more readily available.

I disagree, I feel the config.php file should look like this after a fresh installation
maybe with some comments in place..

Code: Select all

@define('PHPBB_INSTALLED', true);
// @define('PHPBB_DISPLAY_LOAD_TIME', true);
@define('PHPBB_ENVIRONMENT', 'production');
// @define('PHPBB_ENVIRONMENT', 'development');
// @define('DEBUG_CONTAINER', true);

Remember we do not have the SQL explain in place if that file(s) aren't shipped with and also breaks the normal behaviour that's been well known in every version of phpBB till now.
Imagine one day a "Joe Doe" user wants to try and become a coder for phpBB..

[david63]

The problem with that approach is that there will be some who will remove the comment for the development environment, get the error and waste time for support.

Imagine one day a "Joe Doe" user wants to try and become a coder for phpBB..

Then creating a development environment will be their first challenge - once that is done it will be plain sailing from then on

It might be an idea if there was something in the Wiki to explain this

[3Di]

The problem with that approach is that there will be some who will remove the comment for the development environment, get the error and waste time for support.

Imagine one day a "Joe Doe" user wants to try and become a coder for phpBB..

Then creating a development environment will be their first challenge - once that is done it will be plain sailing from then on

It might be an idea if there was something in the Wiki to explain this

Then the line
@define('PHPBB_ENVIRONMENT', 'production');
once commented out should automatically set the 'development' configuration to on.
Sort of "usual" behaviour we all are used to.

Also, as I above stated, a line of comment on this into the config.php should be written, no need to have wiki page. IMO.

[david63]

Then the line
@define('PHPBB_ENVIRONMENT', 'production');
once commented out should automatically set the 'development' configuration to on.

If I recall correctly the way that part of the program works is that if no environment is specified then it will create a production environment

Also, as I above stated, a line of comment on this into the config.php should be written, no need to have wiki page.

I was more meaning that details of the different environments and how to set them up/use them could maybe be in the Wiki

[Nicofuma]

Well...

What is an environment?
An environment is a configuration of the code with different caching strategies, services and debug tools and a dedicated cache directory. As for now (3.2.0-b3-dev) there is 4 environments:

• installer Used by the installer it defines all the services needed to install phpBB. That's a very specific environment that is unable to run a board.
• production Used by default, that's the most efficient configuration. As many things as possible are precomputed and cached (templates event inclusion, container, routing etc...). The drawback being that you need to purge the cache everytime you enable/disable an extension (done automatically) or updates something in the configuration files. (Just to say, my local board, using php 5.6, display a topic page in less than 30ms)
• development Only available on Github, this environment is meant for core contributors and extension developers. It
  • provides a clever caching strategy which looks to your files to guess if the container (or the router) needs to be rebuild which is more powerful (and replaces) than the old DEBUG_CONTAINER constant
  • search the template events at each page instead of caching the list
  • ensures that the dev dependencies of phpBB are installed
  • reloads the templates when they are modified
  • enables a powerful exception and error handler which displays errors and exceptions with many details
  • is much slower than the production one and it should be worse with the time. The goal isn't performance but developer experience.
• test Only available on Github it is used during the tests.

In the future, many more features can be expected in the the development environment, and at the end it should completely (or almost) replace the DEBUG constant.

What should the packages embed?
The answer is simple: only what is needed by the end user so installer and production. The development and test environment can be dangerous if they used on a live board and they aren't meant for the end user at all.
We also assume that an extension developer is able to get the development configuration from Github if he needs it.

Why it is production by default?
Because that's what 99% of the users need and are expecting. Also, we need a default value because when you update your board the config.php file doesn't change and it must remain compatible with the new version of phpBB.

What constant can I define in my config.php file?

Code: Select all

@define('PHPBB_INSTALLED', true);
@define('PHPBB_DISPLAY_LOAD_TIME', true);
@define('PHPBB_ENVIRONMENT', 'production');
@define('DEBUG', true);

• PHPBB_INSTALLED Indicates that the board have been fully installed
• PHPBB_DISPLAY_LOAD_TIME Display the load time of the page, the number of query and the memory peak (doesn't have any performance impact)
• PHPBB_ENVIRONMENT Defines the environment to use. It can have a huge performance and security impact
• DEBUG Enables a few debug settings like the explain. It may disappear in the future, replaced by environments

[3Di]

Thanks, but.. there is not a

Code: Select all

@define('DEBUG', true);

line there.
That's mine live config.php

Code: Select all

@define('PHPBB_INSTALLED', true);
@define('PHPBB_DISPLAY_LOAD_TIME', true);
@define('PHPBB_ENVIRONMENT', 'production');
@define('DEBUG_CONTAINER', true);

So there isn't any explain stuff too.

[3Di]

I manually added that line to my config.php and now it works.
Should be an installer bug then.