PHPBB3-13803 / PHPBB3-13891 - Reparsing text

[Nicofuma]

Done, and the description is fixed.

[Nicofuma]

Current state:

• Implement a reparser service
• Implement a command line to reparse everything
  • Dry run (PR ready)
  • Resume (PR ready)
• Implement reparsing as a cron task

[RMcGirr83]

icon_thumbup.gif (678 Bytes) Viewed 31691 times

[JoshyPHP]

Implement reparsing as a cron task

Talking about cron, while working on --resume I was thinking that the same data used to resume CLI execution could be used for the cron task. It would make it possible to start reparsing with one and finish with the other. If both run at the same time, they'll interfere with each other's resumability but with no ill-effect apart from the wasted CPU cycles. The CLI could automatically postpone the next execution of the cron task to prevent that. During reparser:reparse execution, reschedule the cron task to 10 minutes into the future every time a set of records has been reparsed. It would continuously postpone the cron until the CLI is done or aborted.

[Nicofuma]

Just use a lock in the database (2 actually) and the cron task will be runnable only if they are both released:

For each reparser:
- One reparse_done boolean
- One reparsing boolean

at the beginning of reparse_range, reparsing is set to true
at the end of reparse_range, reparsing is set to false
and in the cron task:
- is_runnable returns !reparse_done
- should_run returns !reparsing

You may need one cron task per reparser plugin but that's not an issue, they can use the same class and you will do everything in the service definition.
You may even reflect reparse_done and reparsing in the reparser plugin itself

[DavidIQ]

icon_thumbup.gif

Off-topic: We should make this part of the default smiley set.

[Pony99CA]

icon_thumbup.gif

Off-topic: We should make this part of the default smiley set.

I think that there should be quite a few extra smilies added, but thumbs up/down would be good starters. Just make sure that they're in the public domain.

Steve

[RMcGirr83]

icon_thumbdown.gif (687 Bytes) Viewed 31410 times

[Kailey]

Just use these

[MattF]

How will this work with extensions that have created their own stored text with bbcodes (Board Rules, Pages, Board Announcements, etc.)?

Is there a method they can call in a migration file or something, to trigger the reparser on the content they have stored?