A quote within a quote notification

[aleha]

With the current notification system I am getting a notification for the following quotation, that is when I am not quoted directly.
Is this behavior intended or is it a bug?

msg1

msg2

[DavidIQ]

I've noticed this as well. I would say it's bug.

[JoshyPHP]

I think the way you'll have to fix it in 3.1 is you'll have to iterate over every quote tag with a regexp like (\[/?quote(?:=".*?"):\w+\]) and maintain a counter with the number of quote tags currently open. And of course, only notify the authors of the outermost quotes.

In 3.2, assuming my PR gets merged, I think the best way to go would be to add a method to phpbb\textformatter\utils_interface that retrieves the quotes' authors from a given text. Messages parsed with s9e\TextFormatter are stored as XML so it's easy to retrieve the outermost quote via XPath with //QUOTE[not(ancestor::QUOTE)]/@author. It may be a good idea to add a user_id parameter to quote tags too.

[aleha]

Reported in the tracker: https://tracker.phpbb.com/browse/PHPBB3-13680

[JoshyPHP]

I'm going to write a fix for 3.2 but I'd need someone to propose a good name for the function that retrieves the names of all authors for first-level quotes. So far I'm thinking about get_quote_authors_but_not_all_of_them_really_only_the_first_level_of_quotes() but I'm open to suggestions.

[Pony99CA]

get_primary_quote_authors
get_top_level_quote_authors
get_first_level_quote_authors
get_outermost_quote_authors

Steve

[Mess]

I'm going to write a fix for 3.2 but I'd need someone to propose a good name for the function that retrieves the names of all authors for first-level quotes. So far I'm thinking about get_quote_authors_but_not_all_of_them_really_only_the_first_level_of_quotes() but I'm open to suggestions.

[JoshyPHP]

get_primary_quote_authors
get_top_level_quote_authors
get_first_level_quote_authors
get_outermost_quote_authors

Steve

get_outermost_quote_authors might just be the best. It's descriptive while remaining short enough.

[aleha]

This was fixed in 3.2 today but it requires a separate solution for 3.1.x.
The ticket for 3.1.x is: https://tracker.phpbb.com/browse/PHPBB3-13855