16px enough, IMHO.hanakin wrote:Code: Select all
font-size: 1.8em; /* 18px */
However, this subject is about max-width, and should not be discussing clutter up font size. Need now set the maximum width and merge pull request.
16px enough, IMHO.hanakin wrote:Code: Select all
font-size: 1.8em; /* 18px */
16px is a minimum.Sumanai wrote:16px enough, IMHO.hanakin wrote:Code: Select all
font-size: 1.8em; /* 18px */
However, this subject is about max-width, and should not be discussing clutter up font size. Need now set the maximum width and merge pull request.
I do agree that their are related areas that should get a similar treatment such as PMs and search. In fact the entire font system really needs rebased, and I have been working on something but its not an easy endeavor as font-sizes and line-heights throughout the entire theme are all em based on top of a 10px base size which is bad practice and leads to infinitely scaling content when it comes to inheritance, but I would hold something of that to a new theme for 3.2.naderman wrote:As just discussed on IRC I do however think we should split it into two PRs, one for the max-width and one for the font size changes, so we can evaluate these independently. Maybe we need a more general approach to a larger font size on bigger screens than just for this one particular area, but I do agree it is needed.
That's bad practice? That's the entire point in ems! I think you're missing ithanakin wrote:In fact the entire font system really needs rebased, and I have been working on something but its not an easy endeavor as font-sizes and line-heights throughout the entire theme are all em based on top of a 10px base size which is bad practice and leads to infinitely scaling content when it comes to inheritance, but I would hold something of that to a new theme for 3.2.
No its a bad practice to use ems because the scaling is compounded which is not desired. The desired result is that its scaled of the root which is where rem comes into the mix.callumacrae wrote:That's bad practice? That's the entire point in ems! I think you're missing ithanakin wrote:In fact the entire font system really needs rebased, and I have been working on something but its not an easy endeavor as font-sizes and line-heights throughout the entire theme are all em based on top of a 10px base size which is bad practice and leads to infinitely scaling content when it comes to inheritance, but I would hold something of that to a new theme for 3.2.
csswizardry wrote: Heights should never be be applied to elements. Heights should only be applied to things which had dimensions before they entered the site (i.e. images and sprites). Never ever set heights on ps, uls, divs, anything. You can often achieve the desired effect with line-height which is far more flexible.