I still think 3. needs discussion as it makes no sense semantically to be in the header. PHPBB really other than the logo has no header content as its ment to be integrated with a website. Where does the search field go when we have a primary navigation form the main site integrated into the header?
Thats why I think it should be in the action bar. Just put it on the right side when on index and where it currently is on the rest of the pages. Or we shove it all the way to the left and keep it their so marks would be on the left of the search and so would paging?
[RFC] Combine Related functionality (UI Cleanup)
Re: Combine all search related functionality
Top websites such as Facebook, Twitter, LinkedIn, YouTube, GitHub, eBay and IMDb have it as high as they can. Competitors such as MyBB and IPB also have it on top right.hanakin wrote:I still think 3. needs discussion as it makes no sense semantically to be in the header. PHPBB really other than the logo has no header content as its ment to be integrated with a website. Where does the search field go when we have a primary navigation form the main site integrated into the header?
Thats why I think it should be in the action bar. Just put it on the right side when on index and where it currently is on the rest of the pages. Or we shove it all the way to the left and keep it their so marks would be on the left of the search and so would paging?
And if we don't place it at the top, we will end up with an empty area just for the logo.
Re: Combine all search related functionality
Ticket: https://tracker.phpbb.com/browse/PHPBB3-12598
PR: https://github.com/phpbb/phpbb/pull/2504
What it currently looks like. Remember, this is just a work-in-progress:
PR: https://github.com/phpbb/phpbb/pull/2504
What it currently looks like. Remember, this is just a work-in-progress:
Last edited by PayBas on Tue May 27, 2014 8:35 pm, edited 1 time in total.
-
- Registered User
- Posts: 523
- Joined: Sat Apr 22, 2006 10:29 pm
- Contact:
Re: Combine all search related functionality
Do we really need the word "View" before each one? The average person would assume that they'll view the respective data after they click the link. The links will be fine with "Your posts", "Unanswered posts", etc.
If it was just one or two of the "View..." then it wouldn't be a big deal. But with so many right behind each other it becomes redundant.
If it was just one or two of the "View..." then it wouldn't be a big deal. But with so many right behind each other it becomes redundant.
Re: Combine all search related functionality
Agreedkeith10456 wrote:Do we really need the word "View" before each one? The average person would assume that they'll view the respective data after they click the link. The links will be fine with "Your posts", "Unanswered posts", etc.
If it was just one or two of the "View..." then it wouldn't be a big deal. But with so many right behind each other it becomes redundant.
Re: Combine all search related functionality
nice i like it press!
@ Louis7777 as for the placement the only reason they all have it at the top is because they have a top bar navigation but prosilver does not have that setup. Semantically the header is only a logo and a search field? WTF it might as well not even be a header just a logo. As I stated before this was done as its meant to be integrated with a fully working site. Notice on area51 the placement of the search field at the top. technically it should be in the top most section where the link to phpbb.com is and the link should be where the search field is.
@ Louis7777 as for the placement the only reason they all have it at the top is because they have a top bar navigation but prosilver does not have that setup. Semantically the header is only a logo and a search field? WTF it might as well not even be a header just a logo. As I stated before this was done as its meant to be integrated with a fully working site. Notice on area51 the placement of the search field at the top. technically it should be in the top most section where the link to phpbb.com is and the link should be where the search field is.
Re: Combine all search related functionality
That is not the reason. The reason is that the search is the most important feature and the user expects to find it at the top.hanakin wrote: @ Louis7777 as for the placement the only reason they all have it at the top is because they have a top bar navigation but prosilver does not have that setup.
Have you seen IPB, MyBB and vBulletin? They have it at the top right.
This forum is in the "Discussion" section of Area51 and it is a website inside Area51. You can't search all Area51 using its search.hanakin wrote: Semantically the header is only a logo and a search field? WTF it might as well not even be a header just a logo. As I stated before this was done as its meant to be integrated with a fully working site. Notice on area51 the placement of the search field at the top. technically it should be in the top most section where the link to phpbb.com is and the link should be where the search field is.
The website's actual top is where "Development Discussion Board" is. Thus, the search field is really at the top right and as high as it can possibly go.
Re: Combine all search related functionality
thats exactly my point! Why it will not fit at the top as its currently designed.
anyway the way the search works needs to be worked out before we can merge the search types anyway
anyway the way the search works needs to be worked out before we can merge the search types anyway
- Darkness_demoN
- Registered User
- Posts: 89
- Joined: Mon Jul 29, 2013 1:48 pm
- Contact:
Re: Combine all search related functionality
I like that! +1PayBas wrote:
Re: Combine all search related functionality
Love it. Great job.PayBas wrote:
+1