[RFC] Hide forum (f) variable from topic url
Re: [RFC] Hide forum (f) variable from topic url
If it's not longer needed in 3.1, I agree.
Member of the phpBB Development-Team
No Support via PM
No Support via PM
-
- Registered User
- Posts: 523
- Joined: Sat Apr 22, 2006 10:29 pm
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
it was required for the breadcrumbs in global announcements the path changes based on the f variable
its not an issue in 3.1 so +1
its not an issue in 3.1 so +1
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
You might want to take a look at all three of those side-by side again.Louis7777 wrote:Well, I don't know in what way it was required, but below there's a global announcement from a 3.0 forum that I chose from the phpBB showcase:
https://forum.videolan.org/viewtopic.php?f=10&t=113882
https://forum.videolan.org/viewtopic.php?f=2&t=113882
https://forum.videolan.org/viewtopic.php?t=113882
As you can see, you can access the same global announcement using different forum IDs and of course without any forum ID in place.
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
We can probably get rid of the forum parameter in the URL. Nevertheless, I would give "canonical link elements" a much higher priority.
Re: [RFC] Hide forum (f) variable from topic url
hi,
And what is the solution for cananical URL? I have a lot of duplicate on google webmaster tool because of &start=0.
I find robot.txt :
Is it good?
URL canonical problem is solved in phpbb 3.1?
thanks,
And what is the solution for cananical URL? I have a lot of duplicate on google webmaster tool because of &start=0.
I find robot.txt :
Code: Select all
User-agent: Mediapartners-Google
Disallow:
User-agent: *
Disallow: /viewtopic.php?p=
Disallow: /viewtopic.php?=&p=
Disallow: /viewtopic.php?t=
Disallow: /viewtopic.php?start=
Disallow: /*&view=previous
Disallow: /*&view=next
Disallow: /*&sid=
Disallow: /*&p=
Disallow: /*&sd=a
Disallow: /*&start=0
URL canonical problem is solved in phpbb 3.1?
thanks,
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
For canonical link elements, which has been (partially?) implemented please see https://area51.phpbb.com/phpBB/viewtopi ... 84&t=42577. Please keep any discussions related to canonical link elements there.
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
I just realised that if we visit the same topic with and without f=
The one without does not display the who is online list.
I tried to investigate it, but it called the same functions with the same parameters, ran the same query and got different results :-O
Okay, so we use f= from the URL and store it in the sessions table.
So when we remove it from the URL, the user is not listed as online in this forum.
Try yourself:
https://area51.phpbb.com/phpBB/viewtopi ... 11#p263511
https://area51.phpbb.com/phpBB/viewtopi ... 08&t=45551
https://area51.phpbb.com/phpBB/viewtopi ... 11#p263511
https://area51.phpbb.com/phpBB/viewtopic.php?t=45551
Code from viewtopic.php:
The one without does not display the who is online list.
I tried to investigate it, but it called the same functions with the same parameters, ran the same query and got different results :-O
Okay, so we use f= from the URL and store it in the sessions table.
So when we remove it from the URL, the user is not listed as online in this forum.
Try yourself:
https://area51.phpbb.com/phpBB/viewtopi ... 11#p263511
https://area51.phpbb.com/phpBB/viewtopi ... 08&t=45551
https://area51.phpbb.com/phpBB/viewtopi ... 11#p263511
https://area51.phpbb.com/phpBB/viewtopic.php?t=45551
Code from viewtopic.php:
Code: Select all
// We overwrite $_REQUEST['f'] if there is no forum specified
// to be able to display the correct online list.
// One downside is that the user currently viewing this topic/post is not taken into account.
if (!request_var('f', 0))
{
$request->overwrite('f', $forum_id);
}
Member of the Development-Team — No Support via PM
- Volksdevil
- Registered User
- Posts: 84
- Joined: Tue Sep 04, 2012 2:17 pm
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
Liking the sound of this as the 'f' parameter has always bothered me, but it seems there is indeed a weird issue with not showing 'yourself' in the online list per forum.
Last edited by Volksdevil on Wed May 28, 2014 10:38 pm, edited 1 time in total.
Superb hosting with Kualo!
My Volkswagen Corrado G60 | Car Wheels Classifieds UK
Vw Corrado G60 Forum | Vw Corrado G60 History | Vw Corrado G60 Buyers Guide
My Volkswagen Corrado G60 | Car Wheels Classifieds UK
Vw Corrado G60 Forum | Vw Corrado G60 History | Vw Corrado G60 Buyers Guide
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC] Hide forum (f) variable from topic url
It's not only about showing "yourself", but it doesnt show "yourself" to anyone. So when we remove it from the URL, the feature becomes quite useless, as everyone does not show to anyone.
Member of the Development-Team — No Support via PM