[RFC] Move navbar(s) to new template file (navbar_header.html)

PayBas · Post by **PayBas** » Wed Apr 09, 2014 12:56 pm

Now that the template engine is much more powerful, I think many style developers will start to use template inheritance more and more. The overall_header.html is of course one of the most important.

Would it be a good idea to move the <div class="navbar"> section to a new template file navbar_header.html?

It's gotten pretty big.

Additionally, we could move the footer navbar as well (to navbar_footer), for symmetry

.

PayBas · Post by **PayBas** » Wed Apr 09, 2014 1:37 pm

Ticket: https://tracker.phpbb.com/browse/PHPBB3-12377
Pull request: https://github.com/phpbb/phpbb/pull/2274

imkingdavid · Post by **imkingdavid** » Sun Apr 13, 2014 3:16 am

This was merged, so I'm moving it to the Merged RFCs forum.

EDIT: I moved it to 3.1 Merged RFCs but it was merged into 3.2 so I'm moving into the 3.2 Merged RFCs forum.

prototech · Post by **prototech** » Sun Apr 13, 2014 8:06 am

It was merged into 3.1. The PR was simply submitted against the wrong branch.

keith10456 · Post by **keith10456** » Sun Apr 13, 2014 11:45 pm

prototech wrote:It was merged into 3.1...

Great news

imkingdavid · Post by **imkingdavid** » Mon Apr 14, 2014 5:45 am

prototech wrote:It was merged into 3.1. The PR was simply submitted against the wrong branch.

Ahh, good catch. Thanks for the correction

Development Discussion Board

[RFC] Move navbar(s) to new template file (navbar_header.html)

[RFC] Move navbar(s) to new template file (navbar_header.html)

Re: [RFC] Move navbar to new template file (overall_header_navbar.html)

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)

Re: [RFC] Move navbar(s) to new template file (navbar_header.html)