Stop disabling super globals

[A_Jelly_Doughnut]

Prior to Symfony Forms 2.3.0, there was no DI available for the class David pointed out.

But, now, there is.
https://github.com/symfony/symfony/blob ... LOG.md#230
(See fourth bullet)
Also, the commit that implements the change

I haven't fully investigated the impllications, but in the 10 minutes I spent on this, it seems easy enough?

(@Exreaction: I didn't immediately see a branch at github.com/exreaction/phpbb3 that made me think "that's the right one", so I didn't look at your code at all, if it is published)

[EXreaction]

Yes, I've been using that (it's an open, WIP PR, but I may not have pushed all of my local changes, it's been a while)

Perhaps it is simply something that was over-looked and needs to be fixed. I've opened a bug ticket on their tracker. https://github.com/symfony/symfony/issues/10009

[sajaki]

hi,
does this mean that in 3.1, this isset ( $_POST ['templatevariable'] won't work because there's no $_POST array anymore ?

[imkingdavid]

hi,
does this mean that in 3.1, this isset ( $_POST ['templatevariable'] won't work because there's no $_POST array anymore ?

I believe isset() is allowed, but in 3.1 is it strongly recommended that you just use $request->is_set_post('templatevariable');

[Marc]

Please don't use globals like $_POST in 3.1. There are methods like $request->is_set() and $request->is_set_post().

[wintstar]

I have a problem with

Code: Select all

$this->setSessionIP($_SERVER['REMOTE_ADDR']);

Error message
Illegal use of $_SERVER. You must use the request class or request_var() to access input data. This error message was generated by deactivated_super_global.

[Marc]

Maybe use $request->server('REMOTE_ADDR')?

[wintstar]

Thanks Marc, but comes the next Error

Undefined variable: request

[Marc]

You have to use the global variable $request or pass the request class to your service container. It obviously won't work otherwise.

[wintstar]

Thanks Marc, that helps me to further.