[RFC] Integrate s9e\TextFormatter

[Pony99CA]

Do the event names really need "s9e" in them? Technology names shouldn't be in events, should they? For example, isn't core.text_formatter_configure_before good enough?

Steve

[JoshyPHP]

No, because there's no universal API to code against. The core.text_formatter_s9e_configure_before event gives you an instance of s9e\TextFormatter\Configurator and then you use its API.

[Nicofuma]

Merged, but we still have a lot of things to do (new tickets/new PRs )

• Add a cron job to silently reparse all the posts
• Design an API/Interface for the whole text formatting thingy (I mean: replace generate_text_for_*, includes/bbcode.php and includes/message_parser.php)
• At least make includes/message_parser.php autoloadable
• We don't want to fix message_parser to be PHP7 compatible, so we need to reparse the posts on the fly (if needed) when we try to display them.

[JoshyPHP]

Great news.

Merged, but we still have a lot of things to do (new tickets/new PRs )

Indeed. I would be great if you'd create a thread for each of those to get the discussion started. Also useful: an outline of your timetable for those, or perhaps rather which version(s) you want to target.

I have looked into using cron to convert posts in the background. The conversion itself is simple (load/unparse/reparse/save) but the last time I looked into it I identified at least 9 different places where rich text is stored. The task is not as straightforward as it may seem at first glance. I have more thoughts on the matter that I'll share in the relevant topic. I haven't fleshed them out in the form of working code but there's a good chance I'll take over that task.

As for the rest of the bullet points I don't have much insight.

[brunoais]

A post was made in this topic... where is it?

[JoshyPHP]

https://area51.phpbb.com/phpBB/viewtopi ... 41#p281441

[brunoais]

Thank you.

[Hunchman801]

Great job, this really is a huge step forward.

I understand this fixes custom BBCode nesting, such as:

Code: Select all

[spoiler][spoiler]text[/spoiler][/spoiler]

But does it also prevent it from breaking the page layout, as can be done with the following:

Code: Select all

[quote][spoiler][/quote][/spoiler]

In that case, which tag(s) would be processed? Quote, spoiler, or none?

Note: I know spoiler's not standard but this happens with every single implementation of it, it's basically just a div.

[JoshyPHP]

Off the top of my head, it would be interpreted as the following:

Code: Select all

[quote][spoiler][/spoiler][/quote][/spoiler]

The spoiler div stops at the end of the quote and you see a lone, unused [/spoiler] BBCode after the quote.

[xiri]

Hello.
Help me to understand why different versions of phpbb differently write data into the database. For example:

3.1:

Code: Select all

[quote:3olk12uy]123цитата[/quote:3olk12uy]

3.2:

Code: Select all

<r><QUOTE><s>[quote]</s>123цитата <e>[/quote]</e></QUOTE></r>

Why 3.2 version of parsing is better?
Thanks in advance!