[RFC] Notify the user of skipped migrations due to missing dependencies unless explicitly suppressed

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
rechosen
Registered User
Posts: 4
Joined: Thu Apr 11, 2013 8:15 am

[RFC] Notify the user of skipped migrations due to missing dependencies unless explicitly suppressed

Post by rechosen »

Currently, if the dependencies of a migration cannot be satisfied, that migration will not be run and any operation trying to apply the migration will succeed without notifying the user that it skipped something. This causes unwanted behavior when, for example, an extension is enabled and not all dependencies of the migration adding the necessary database tables are met. The extension will enable without apparent problems, but fail whenever it tries to access the database.

To prevent this behavior, it is desirable that some kind of notice about the skipping is given to the user unless the migration author explicitly suppresses this. On #phpBB-dev it was suggested that there should be multiple types of dependencies to discern between dependencies that should fail silently and noisily.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-11627

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Notify the user of skipped migrations due to missing dependencies unless explicitly suppressed

Post by imkingdavid »

I agree that we should differentiate between dependencies that can be skipped and dependencies that are actually dependencies. In both cases, the person installing the extension should be notified and, in the former case, should be given the option to either continue or abort (revert any changes that have been made) installation. The latter case would automatically abort and display a failure message. We should default to the latter but allow extension authors to specify that a given dependency can be missing.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply