Dropping the tests/functional directory

[bantu]

I am not sure whether there was a good reason for having functional tests separate in the tests/functional directory or whether it was just for technical reasons. PHPUnit's grouping annotation (@group functional) seems to be sufficient and would allow tests to be grouped by topic/feature instead of having functional tests separate. Therefore I am proposing dropping the tests/functional directory and moving existing tests into the existing structure.

[imkingdavid]

I like having the separation so that I know which ones are functional and which aren't without having to look inside the file. But I suppose I would be okay with this if you guys decide to do this.

[MichaelC]

I like having the separation so that I know which ones are functional and which aren't without having to look inside the file. But I suppose I would be okay with this if you guys decide to do this.

+1 to that.

[bantu]

Well, they are in different test suites, so from that perspective I guess it makes sense. On the other hand, you have to visit two places when it comes to the question whether something has test coverage.

[imkingdavid]

Can we add "_functional" or prefix with "functional_" to all functional test files? If so, that would eliminate the need for a separate folder.

[Oleg]

I am not seeing how functional tests (which cover multiple units) would fit into unit test directory structure.

I cannot recall a single project that mixed unit and functional tests like that.

I wrote test suites that folded unit tests into integration tests, but this is opposite direction of what is being proposed here.

Let's see the patch doing just the renames?

[bantu]

Let's see the patch doing just the renames?

I haven't done any work for this yet, basically just wanted to know whether there was a good reason for having them separate.

[Oleg]

I am not seeing how functional tests (which cover multiple units) would fit into unit test directory structure.

would be my concern.

What is an example situation where it is unclear where a test for something is?

[imkingdavid]

I don't think he's concerned that it's unclear whether or not a test exists for a given feature, I think he's more concerned with having to check multiple places to find it out.

[MichaelC]

Do we not have anything that checks code coverage of phpBB?