[RFC] Extend Existing Implementation of AJAX in ACP

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

[RFC] Extend Existing Implementation of AJAX in ACP

Post by VSE »

There is a basic set of AJAX functions for use in the ACP provided by this file: https://github.com/phpbb/phpbb3/blob/de ... le/ajax.js

I noticed that the AJAX-based row_up and row_down functions are only currently implemented on the Manage Forums page in the ACP. It AJAX-ifies the Move-Up and Move-Down buttons so no page reloads occur when re-ordering forums.

There are many other areas in the ACP where these same Move-Up and Move-down buttons are used to order items, but still work the old-fashioned way with page reloads for each click:

* Smilies (acp_icons.html)
* Topic Icons (acp_icons.html)
* Custom Profile Fields (acp_profile.html)
* Manage Group Positions (cap_groups_position.html)
* Permissions Roles (acp_permission_roles.html)
* Module Management (acp_modules.html)
* Manage Report/Denial Reasons (acp_reasons.html)

It would make sense, and be more consistent, that this functionality be extended to all of the above, rather than just the Forums Management alone as it currently stands in the Dev branch.
Has an irascible disposition.


User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by Pony99CA »

Yes, and maybe add Move to Top and Move to Bottom functions, too.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by keith10456 »

Pony99CA wrote:Yes, and maybe add Move to Top and Move to Bottom functions, too.

Steve
+1

User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by Jessica. »

Can it maybe be a drag and drop instead? Might be easier than ajax move up and down, because you still have to click a lot of times if you want to move a forum to a place that's far up (or down)

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 160
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by Marc »

That would probably be something for jQuery UI: http://jqueryui.com/

We should however make sure that you can't just drag & drop something by accident.

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 935
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by hanakin »

+1
Jessica. wrote:Can it maybe be a drag and drop instead? Might be easier than ajax move up and down, because you still have to click a lot of times if you want to move a forum to a place that's far up (or down)
Agree seeing as how Ex made a mod to add this function to te forumlist not sure why it can not be used for the acp
Donations welcome via Paypal Image

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 674
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by VSE »

Thought I should add that the AJAX implemented in the ACP is also, quite broken!

Whenever a button presents the AJAXified Confirm dialog in a modal, it does not work. So Purging the Cache does not work, deleting various things such as modules, bbcodes, etc. do not work.

http://tracker.phpbb.com/browse/PHPBB3-11442
Has an irascible disposition.

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by PayBas »

I really think we should give this a shot: http://api.jqueryui.com/sortable/

The up/down arrows just don't cut it anymore in 2014

User avatar
Louis7777
Registered User
Posts: 390
Joined: Fri Apr 04, 2014 12:32 am

Re: [RFC] Extend Existing Implementation of AJAX in ACP

Post by Louis7777 »

PayBas wrote:I really think we should give this a shot: http://api.jqueryui.com/sortable/

The up/down arrows just don't cut it anymore in 2014
+1 :)

Post Reply