Adding phpbb prefix to functions

[imkingdavid]

I suppose if all call sites are going to have to be changed anyway, it wouldn't hurt. But in the case of an optional parameter being added at the end, that does not count because not all call sites would have to be changed.

[callumacrae]

We are not going to be changing all functions. This involves too much work and will break everything because we don't have 100% test coverage, not to mention political unrest.

Can we keep on topic please? The case we are discussing changes required parameters which necessitates all call sites to be edited regardless of whether prefix is added or not.

Any decent IDE can change a function name and all calls.

[DavidIQ]

We are not going to be changing all functions. This involves too much work and will break everything because we don't have 100% test coverage, not to mention political unrest.

Can we keep on topic please? The case we are discussing changes required parameters which necessitates all call sites to be edited regardless of whether prefix is added or not.

Any decent IDE can change a function name and all calls.

Yep...and break almost every single MOD out there even if it had a chance it would still work in 3.1.

[MichaelC]

We are not going to be changing all functions. This involves too much work and will break everything because we don't have 100% test coverage, not to mention political unrest.

Can we keep on topic please? The case we are discussing changes required parameters which necessitates all call sites to be edited regardless of whether prefix is added or not.

Any decent IDE can change a function name and all calls.

Yep...and break almost every single MOD out there even if it had a chance it would still work in 3.1.

Hence the reason we don't plan to change functions un-necessarily.

[brunoais]

We are not going to be changing all functions. This involves too much work and will break everything because we don't have 100% test coverage, not to mention political unrest.

Can we keep on topic please? The case we are discussing changes required parameters which necessitates all call sites to be edited regardless of whether prefix is added or not.

Any decent IDE can change a function name and all calls.

Yep...and break almost every single MOD out there even if it had a chance it would still work in 3.1.

How about if we use that in conjunction to what I proposed?

[MichaelC]

How about if we use that in conjunction to what I proposed?

Then it adds a lot of overhead with little rewards/advantage.

[bantu]

Considering that most of phpBB's functions are not prefixed, how about this:

1. Get rid of global statements in all functions for dependency injection (changing parameter list)
2. Add phpbb_ prefix to all function names
3. Create 3.1 to 3.0 compatibility file with wrappers basically as per https://area51.phpbb.com/phpBB/viewtopi ... 53#p249253 importing variables from global space

Result: Dependency Injection + Easier/Better Unit Testing

3.0 modifications can then either

• be ported to 3.1 extensions (best)
• be ported to 3.1 modifications (updating function calls)
• include the compatibility file (basically saying "I just want this to work for now")

The compatibility file is not loaded by phpBB itself.

[Oleg]

That is very agreeable.

[EXreaction]

I would agree to that except for requiring that mods include a compatibility file. This would require them to update anyways to include the file, so it would not be of benefit.

I would be good with one of the following:
1. Just include the compatibility file
2. Create a constant in the config file for new installs (PHPBB_COMPATIBILITY_MODE, set to false). If this constant is not set or is true, include the file, else do not.

Both options would preserve compatibility for upgrades, but the second option, for fresh installs, having it disabled would require administrators to enable it if they want to attempt to install old modifications.

[MichaelC]

I would agree to that except for requiring that mods include a compatibility file. This would require them to update anyways to include the file, so it would not be of benefit.

I would be good with one of the following:
1. Just include the compatibility file
2. Create a constant in the config file for new installs (PHPBB_COMPATIBILITY_MODE, set to false). If this constant is not set or is true, include the file, else do not.

Both options would preserve compatibility for upgrades, but the second option, for fresh installs, having it disabled would require administrators to enable it if they want to attempt to install old modifications.

+1