stopPropagation() doesn't stop the link from being followed.
Using CSS animations seems a bit pointless. Sure, it might use a teensy bit less CPU, but it doesn't work on all browsers.
Integrating automatic image resizing
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: Integrating automatic image resizing
ok.callumacrae wrote:stopPropagation() doesn't stop the link from being followed.
Not a teensy in my PC... I think 10% difference, or so.callumacrae wrote:Using CSS animations seems a bit pointless. Sure, it might use a teensy bit less CPU, but it doesn't work on all browsers.
Personally I don't care about older browsers when what's in cause is just something to make it look more "beautiful transaction between 2 states". I don't know what's the way of working in phpBB for that, though.
That comes with more concerns we need to decide if we are going to solve or not.
- If the image is larger than the screen size. How should it be done?
- If the image would fit the screen if it was aligned to the left side of the screen, should it adjust that or just not care?
- What's the size used to show when showing in the zoomed size? The max between the screen size and the image? Just the image size?
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: Integrating automatic image resizing
Horizontal scrolling? If the user is expanding an image, they should expect it to get bigger.brunoais wrote: [*]If the image is larger than the screen size. How should it be done?
I have no idea what you mean by these twobrunoais wrote: [*]If the image would fit the screen if it was aligned to the left side of the screen, should it adjust that or just not care?
[*]What's the size used to show when showing in the zoomed size? The max between the screen size and the image? Just the image size?[/list]
Re: Integrating automatic image resizing
Please no, I hate horizontal scrolling similar smf stylecallumacrae wrote:Horizontal scrolling? If the user is expanding an image, they should expect it to get bigger.brunoais wrote: [*]If the image is larger than the screen size. How should it be done?
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: Integrating automatic image resizing
How do you suggest this be done, then? Force the user to open the image in a new tab? That would involve horizontal scrolling, too.MaFeSa wrote:Please no, I hate horizontal scrolling similar smf stylecallumacrae wrote:Horizontal scrolling? If the user is expanding an image, they should expect it to get bigger.brunoais wrote: [*]If the image is larger than the screen size. How should it be done?
Please think your comment through in the context of the topic.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: Integrating automatic image resizing
How about this:
First, expand to, at maximum, the width of the user's screen.
Second, if the width of the image is still larger, provide a link to the full image (original size) in a new tab.
First, expand to, at maximum, the width of the user's screen.
Second, if the width of the image is still larger, provide a link to the full image (original size) in a new tab.
Re: Integrating automatic image resizing
I like EXreaction's idea.
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: Integrating automatic image resizing
Why in a new tab? Why not just give the user the option to expand it in the current tab? It's exactly the same behaviour, but opening it in a new tab seems like horrible behaviour to me.EXreaction wrote:How about this:
First, expand to, at maximum, the width of the user's screen.
Second, if the width of the image is still larger, provide a link to the full image (original size) in a new tab.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: Integrating automatic image resizing
Opening in the current tab is probably the most proper behavior, that gives the user the option to open in a new tab or current if they want.callumacrae wrote:Why in a new tab? Why not just give the user the option to expand it in the current tab? It's exactly the same behaviour, but opening it in a new tab seems like horrible behaviour to me.EXreaction wrote:How about this:
First, expand to, at maximum, the width of the user's screen.
Second, if the width of the image is still larger, provide a link to the full image (original size) in a new tab.