Placeholder for search box.

[Dragosvr92]

As phpbb 3.1.0 finally changed from image-round corners, to borderradius, i think you should also change this bit on the search form.

Find:

Code: Select all

<input name="keywords" id="keywords" type="text" maxlength="128" title="{L_SEARCH_KEYWORDS}" class="inputbox search" value="<!-- IF SEARCH_WORDS-->{SEARCH_WORDS}<!-- ELSE -->{L_SEARCH_MINI}<!-- ENDIF -->" onclick="if(this.value=='{LA_SEARCH_MINI}')this.value='';" onblur="if(this.value=='')this.value='{LA_SEARCH_MINI}';" /> 

Replace with:

Code: Select all

<input name="keywords" id="keywords" type="text" maxlength="128" title="{L_SEARCH_KEYWORDS}" class="inputbox search" value="<!-- IF SEARCH_WORDS-->{SEARCH_WORDS}<!-- ELSE -->{L_SEARCH_MINI}<!-- ENDIF -->" placeholder="{LA_SEARCH_MINI}" /> 

We already use the html5 doctype, so the placeholder should validate.
The current way of doing it withthe onclick/onblur looks a bit messy/long to me, with that javascript in.
Also, it doesnt work right. If you right click the form the message does not disappear.. Thoughts?

[psoTFX]

Seems sensible to me - though on chrome the placeholder vanishes.

[Dragosvr92]

You are right, sort of. The placeholder text doesnt vanish. it stays there as background text, till you write something. Wont dis/re-appear on mouse click.

[naderman]

Sounds like a good idea, just create a ticket and send a pull request please.

[Vinny]

Good idea. +1

[Senky]

+1

[callumacrae]

+1 - but possibly write some code that detects whether placeholder is available (modernizr, anyone?) and adds an onclick fallback.

[Dragosvr92]

I created the ticket, but what pull request?

@callum, i thought about that, to support older browsers too, but it may be too messy to support older browsers.

border radius isnt supported on older browsers (IE8 etc) and no hack was included in phpbb.

[callumacrae]

It's a very easy fallback to implement, unlike with border-radius which would be horrific. Also, with "Search" it isn't too clear what the box does.

[nickvergessen]

As per viewtopic.php?f=108&t=43115 the data attribute should be prefixed with phpbb-data-*

Edit: sorry I misunderstood this, I thought it was ment to be implemented with ajax. But maybe that's still interesting for the fall back