[RFC|Rejected] Font sizes as font sizes
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
[RFC|Rejected] Font sizes as font sizes
I really don't understand why the size BBCode uses random numbers. Why not just accept 16pt, 18px as sizes? I know what 16pt is, but I don't know what 200 is, so I have to use the button every time I want to change the size, when it might want to type it.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Font sizes as font sizes
Currently it goes by percent, afaik. i.e. 200 is 2x normal font size. 100 is normal font size (i.e. 100%). I don't have a problem with using pt and px as well if either is specified, but we should not remove the current percentage functionality, especially so we don't break BC.
Re: [RFC] Font sizes as font sizes
I go with adding functionality so that we could also use pt.
Should be something valid...
Code: Select all
[size=20pt][/size]
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Font sizes as font sizes
I think if we allow non-integer characters, those should be in quotes. But I'm not sure how it all works right now with the current bbcode parser, so i'm not sure if we can allow both with and without quotes depending on the value.
Re: [RFC] Font sizes as font sizes
I think percentages are fine.
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: [RFC] Font sizes as font sizes
I had absolutely no idea that they were percentages, and I'm on the team. It should be obvious how the sizes work.Oleg wrote:I think percentages are fine.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Font sizes as font sizes
If using "Normal" size creates acallumacrae wrote:I had absolutely no idea that they were percentages, and I'm on the team. It should be obvious how the sizes work.Oleg wrote:I think percentages are fine.
Code: Select all
[size=100][/size]
Anyway, as I said, as long as we retain current behavior for the bbcode button, I'm okay with someone implementing the ability to use pt and px for those who know how. However percents of > 200 and < 50 are not accepted by the BBcode engine, so if pt and px are implemented, they should have a maximum and minimum that are equal to the size created by using percents (I'm not sure offhand what they are, you'd have to take font size at 100% and determine its pt and px and then calculate the pt and px for fonts at 50 and 200 percent).
Re: [RFC] Font sizes as font sizes
Relative font sizes have the advantage of working when font size changes.
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: [RFC] Font sizes as font sizes
Which was removed in 3.1Oleg wrote:Relative font sizes have the advantage of working when font size changes.
Re: [RFC] Font sizes as font sizes
But styles might still use different font size.callumacrae wrote:Which was removed in 3.1Oleg wrote:Relative font sizes have the advantage of working when font size changes.
Default prosilver uses 13px Lucida Grande or Trebuchet MS font. If its changed to Arial or Helvetica, font would become smaller. To make bbcode look the same, font=100 must be 13px for prosilver, 14px for style that uses Arial. Using percentages makes much more sense.
Formerly known as CyberAlien.
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts