[RFC] AJAX Quick Edit

[callumacrae]

Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.

Ok. Just tried out implementing what I thought would be good...

Anyway, what about an inline text area that is hidden, which fades in on clicking the edit button? I think that would do for a quick edit...

Can become too much data for a single thread. This means to the browser to download the double of the information for editable posts which can become heavy.

I wouldn't describe it as heavy, but it's not required.

[AliasM2K]

You should send an AJAX request requesting the BBCode, then create the textarea and insert the BBCode into it.

That have be done... The text area should be filled with the post's bbcode. Else, what could be edited?

I wouldn't describe it as heavy, but it's not required.

I think so too... An inline editor, using a bit of AJAX to load bbcode won't be that heavy.

Personally, I'd love to implement this patch on phpBB... I know this is not the right place to ask, but how am I to contribute to the code?

[callumacrae]

Create a ticket on the tracker. Then clone the phpbb repo from GitHub, and branch the develop branch into ticket/ticketid. Make your changes, commit them, and then push them and send a PR.

http://wiki.phpbb.com/Git

[AliasM2K]

Create a ticket on the tracker. Then clone the phpbb repo from GitHub, and branch the develop branch into ticket/ticketid. Make your changes, commit them, and then push them and send a PR.

http://wiki.phpbb.com/Git

Thanks... Attempting the patch now.

[AliasM2K]

And, here is a live demo of my implementation plan.

Using markItUp jQuery plugin for fun, and also the buttons Full Editor and Submit are dummies. The idea is to hide the post and display the editor.

The demo is not a big deal... I am just posting it to see if that is what you expected.

[brunoais]

The demo is not a big deal... I am just posting it to see if that is what you expected.

That kind of behaviour is what I'm after.
Check this too:
http://userscripts.org/scripts/show/11064
It also has the same idea.

[callumacrae]

And, here is a live demo of my implementation plan.

Using markItUp jQuery plugin for fun, and also the buttons Full Editor and Submit are dummies. The idea is to hide the post and display the editor.

The demo is not a big deal... I am just posting it to see if that is what you expected.

Demo doesn't appear to be working properly (or I'm getting confused).

Take a look at this, it is kinda what I'm expecting (although obviously this is only a very basic example): http://jsfiddle.net/ZabMY/

[AliasM2K]

Demo doesn't appear to be working properly (or I'm getting confused).

Take a look at this, it is kinda what I'm expecting (although obviously this is only a very basic example): http://jsfiddle.net/ZabMY/

Got the idea... Thanks...

[Marc]

I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.

[jsebean]

I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.

Very nice mod indeed my favorite part of jquery base is the quick reply without refresh.