[RFC|Merged] Template tag to include JS files

[Arty]

EDIT: Ignore that, you're using INCLDEJS. Why are you using INCLUDEJS? XD

To enable template inheritance for it. Until RFC for T_STYLE_PATH (inheritance for all components) will be implemented, INCLUDEJS is the only way to allow inheritance for javascript files.

[callumacrae]

Aha, I see. Fair enough.

[Dragosvr92]

Will phpbb variables be parsed if in javascript files?

Like, will {T_STYLE_PATH} be parsed in a js file same as it gets parsed into a html file?
I needed to do this on the Lightbox MOD and it didnt work.

[callumacrae]

Will phpbb variables be parsed if in javascript files?

Like, will {T_STYLE_PATH} be parsed in a js file same as it gets parsed into a html file?
I needed to do this on the Lightbox MOD and it didnt work.

No.

[Arty]

Wiki article that includes this change: http://wiki.phpbb.com/New_Template_Commands_in_3.1

[brunoais]

Wiki article that includes this change: http://wiki.phpbb.com/New_Template_Commands_in_3.1

Please confirm:
Does it keep the order of the INCLUDEJS tags? If it does that's something important to specify in the wiki.

An example would also be nice. Because I still don't know >90% how it works, it's better for you to write that example.
Anyway:
Great feature, dude!

[callumacrae]

Wiki article that includes this change: http://wiki.phpbb.com/New_Template_Commands_in_3.1

Please confirm:
Does it keep the order of the INCLUDEJS tags? If it does that's something important to specify in the wiki.

An example would also be nice. Because I still don't know >90% how it works, it's better for you to write that example.
Anyway:
Great feature, dude!

Yes, it will keep the order.

What don't you get about the example on the wiki article? You call the INCLUDEJS function, it inserts the script after the jQuery tag…

[Arty]

I've added example to wiki to make things clearer.

[brunoais]

Your changes do not answer my question.
You state that all script tags are placed after jQuery's script tag. That's ok and was already there.
Another thing you do not tell in the wiki:
Do tag order maintains?
In the code:

Code: Select all

<!-- overall_header.html -->
	header stuff here
<!-- end of overall_header.html -->
<!-- custom template -->
	<!-- INCLUDEJS template/custom1.js -->
	Some content
	<!-- INCLUDEJS template/custom2.js -->
<!-- end of custom template -->
<!-- overall_footer.html -->
	<!-- INCLUDEJS template/custom3.js -->
	footer code here
	jQuery is included here
	</body>
</html>
<!-- end of overall_footer.html -->

Can it become?

Code: Select all

header stuff here
some content
footer code here
jQuery is included here
<script src="./styles/prosilver/template/custom3.js"></script>
<script src="./styles/prosilver/template/custom1.js"></script>
<script src="./styles/prosilver/template/custom2.js"></script>
</body>
</html>

Does the tag order in the files persist? You do not specify that anywhere in that wiki article.

[Arty]

Yes, that's exactly what it will become