These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
naderman wrote:The way I see this is the following: We want to finish 3.1 as soon as possible. Extensions need to be finished to release 3.1. Extensions would be easier and quicker to implement fully if we could use third party components for them. Third party components we would like to use for extensions require PHP 5.3. So let's just require PHP 5.3, to get 3.1 done already, so we can move on.
Which libraries are you thinking of?
Oleg wrote:If that is the case it seems perfectly ok to me to require 5.3. Any hosts still using 5.2 must either compile it themselves or use unofficial packages; in either case it is legitimate to ask them to provide 5.3.
Therefore
Erik Frèrejean wrote:
igorw wrote:At this point it just doesn't make sense to support PHP 5.2.
What percentage of phpBB boards run PHP 5.3?
We have a nice statistics thingy. How large is the user base that still runs 5.2? Breaking backwards compatibility shouldn't be taken to light hearted, how many users will be affected by this and does the potential gain outweigh the size of the user base that is still on that platform.
Erik Frèrejean wrote:Which libraries are you thinking of?
igorw wrote:Use Symfony2 EventDispatcher instead of copy-paste maintaining the code base (see this PR)
Oleg wrote:We could use event dispatcher verbatim and I think a dependency injection container along with an asset management contraption would be handy as well.
Erik Frèrejean wrote:We have a nice statistics thingy. How large is the user base that still runs 5.2? Breaking backwards compatibility shouldn't be taken to light hearted, how many users will be affected by this and does the potential gain outweigh the size of the user base that is still on that platform.
Someone with access (i.e. management) would have to run some queries again. Last time we did, most (around 80-90%) new installations were on PHP <=5.2. It may have improved a bit by now, but I'm guessing not much. I have already given my opinion on the matter.
Erik Frèrejean wrote:We have a nice statistics thingy. How large is the user base that still runs 5.2? Breaking backwards compatibility shouldn't be taken to light hearted, how many users will be affected by this and does the potential gain outweigh the size of the user base that is still on that platform.
Someone with access (i.e. management) would have to run some queries again. Last time we did, most (around 80-90%) new installations were on PHP <=5.2. It may have improved a bit by now, but I'm guessing not much. I have already given my opinion on the matter.
If that is indeed the case I'm sorry to say that this is a no-brainer, you just can't defend breaking compatibility for such a large part of your user base.
igorw wrote:
Erik Frèrejean wrote:Which libraries are you thinking of?
igorw wrote:Use Symfony2 EventDispatcher instead of copy-paste maintaining the code base (see this PR)
PHP 5.3 was released in june 2009, more or less like IE8. If we think IE7 is outdated we could make the same assumption about PHP 5.2, I guess.
It's true that a lot of hosts still deploy php 5.2 and 5.1 (Centos 5, Debian 5...), and they will still do in the future as long as people don't ask them to update.
I say, make an announcement now and give hosts a few months to update (you -meaning manage team or whoever- could even talk in private with a few of them if you have the possibility). Tell admins they need to poke their hosts (or update themselves). phpBB is not the center of the world but I honestly think lots os hosts will prefer to update than listen to the complaints/requests of forum users. When a considerable ammount of them had updated the others will need to follow.
I don't think this is an unreasonable request. It certainly is a step ahead.
Based on this, I think it's fair to assume that by the time 3.1 is released, 5.3 and 5.4 will make up a large majority of our users' platforms. Certainly enough to simply force the rest to upgrade their PHP to 5.3 if they want to update to phpBB 3.1. Do keep in mind that we will continue to support 3.0.x for a while after the release 3.1 as well. So I really do not see a problem with requiring PHP 5.3 at all.