I completely agree. If there are users still on 2.0 then they can upgrade to 3.0 first and then to 3.1. Let's cut out some of the excess fat.igorw wrote:On topic: I don't think we need 2.0 => 3.1 conversion.
[RFC] Remove phpBB 2 Convertor
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: [RFC] Remove phpBB 2 Convertor
- DarkBeing
- Registered User
- Posts: 83
- Joined: Sun Jul 19, 2009 2:32 pm
- Location: Currently Estonia
- Contact:
Re: [RFC] Remove phpBB 2 Convertor
+1DavidIQ wrote:I completely agree. If there are users still on 2.0 then they can upgrade to 3.0 first and then to 3.1. Let's cut out some of the excess fat.igorw wrote:On topic: I don't think we need 2.0 => 3.1 conversion.
- Erik Frèrejean
- Registered User
- Posts: 207
- Joined: Thu Oct 25, 2007 2:25 pm
- Location: surfnet
- Contact:
Re: [RFC] Remove phpBB 2 Convertor
ThatNoxwizard wrote:We still see support topics every week about converting from phpBB2. If it works, I would suggest leaving it. If it is sufficiently broken, then I wouldn't put much effort into fixing it.
Available on .com
Support Toolkit developer
Support Toolkit developer
Re: [RFC] Remove phpBB 2 Convertor
Since testing the converter requires a phpbb 2 board, if anyone wants to see it remain part of phpbb 3.1 they need to check if it is still working.
If there is no one who cares enough to test the converter, we should probably remove it.
Note that there is already a PR to remove it. If there are no volunteers who would test it I will merge that PR at some point.
If there is no one who cares enough to test the converter, we should probably remove it.
Note that there is already a PR to remove it. If there are no volunteers who would test it I will merge that PR at some point.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Remove phpBB 2 Convertor
IMO, it makes no sense to include a 2.0->3.0 converter in the 3.1 core package. If it were a 2.0->3.1 converter, then sure. If someone wants to convert from 2.0->3.1, they need to download 3.0 anyway to convert to that, and then upgrade to 3.1 from 3.0.
Re: [RFC] Remove phpBB 2 Convertor
One simply needs to ask. The only issue with the convertor in 3.1 right now is that the search systems are now prefixed withOleg wrote:If there is no one who cares enough to test the converter, we should probably remove it.
phpbb_search_
. The file name differs from the class name, so instantiating the class fails on line 755. This could be remedied by pre-pending $search_type
with the prefix. (Edit, this has been fixed by PHPBB3-10637) Other than that, it doesn't appear to have any issues converting everything.It wouldn't go to 3.0, it would be going 3.1. Unless there are significant database structure changes, the current convertor will most likely continue to work with 3.1.imkingdavid wrote:IMO, it makes no sense to include a 2.0->3.0 converter in the 3.1 core package. If it were a 2.0->3.1 converter, then sure. If someone wants to convert from 2.0->3.1, they need to download 3.0 anyway to convert to that, and then upgrade to 3.1 from 3.0.
Re: [RFC] Remove phpBB 2 Convertor
The converter will still be available, just not in the default package, similar to how subsilver 2 will be. Available but not in the main package.
Formerly known as Unknown Bliss
No unsolicited PMs please except for quotes.psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"