[RFC] Remove phpBB 2 Convertor

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Remove phpBB 2 Convertor

Post by DavidIQ »

igorw wrote:On topic: I don't think we need 2.0 => 3.1 conversion.
I completely agree. If there are users still on 2.0 then they can upgrade to 3.0 first and then to 3.1. Let's cut out some of the excess fat. :-)
Image

User avatar
DarkBeing
Registered User
Posts: 83
Joined: Sun Jul 19, 2009 2:32 pm
Location: Currently Estonia
Contact:

Re: [RFC] Remove phpBB 2 Convertor

Post by DarkBeing »

DavidIQ wrote:
igorw wrote:On topic: I don't think we need 2.0 => 3.1 conversion.
I completely agree. If there are users still on 2.0 then they can upgrade to 3.0 first and then to 3.1. Let's cut out some of the excess fat. :-)
+1

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] Remove phpBB 2 Convertor

Post by Erik Frèrejean »

Noxwizard wrote:We still see support topics every week about converting from phpBB2. If it works, I would suggest leaving it. If it is sufficiently broken, then I wouldn't put much effort into fixing it.
That
Available on .com
Support Toolkit developer

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Remove phpBB 2 Convertor

Post by Oleg »

Since testing the converter requires a phpbb 2 board, if anyone wants to see it remain part of phpbb 3.1 they need to check if it is still working.

If there is no one who cares enough to test the converter, we should probably remove it.

Note that there is already a PR to remove it. If there are no volunteers who would test it I will merge that PR at some point.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove phpBB 2 Convertor

Post by imkingdavid »

IMO, it makes no sense to include a 2.0->3.0 converter in the 3.1 core package. If it were a 2.0->3.1 converter, then sure. If someone wants to convert from 2.0->3.1, they need to download 3.0 anyway to convert to that, and then upgrade to 3.1 from 3.0.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Noxwizard
Support Team Leader
Support Team Leader
Posts: 138
Joined: Sun Dec 18, 2005 5:44 pm
Location: Texas
Contact:

Re: [RFC] Remove phpBB 2 Convertor

Post by Noxwizard »

Oleg wrote:If there is no one who cares enough to test the converter, we should probably remove it.
One simply needs to ask. The only issue with the convertor in 3.1 right now is that the search systems are now prefixed with phpbb_search_. The file name differs from the class name, so instantiating the class fails on line 755. This could be remedied by pre-pending $search_type with the prefix. (Edit, this has been fixed by PHPBB3-10637) Other than that, it doesn't appear to have any issues converting everything.
imkingdavid wrote:IMO, it makes no sense to include a 2.0->3.0 converter in the 3.1 core package. If it were a 2.0->3.1 converter, then sure. If someone wants to convert from 2.0->3.1, they need to download 3.0 anyway to convert to that, and then upgrade to 3.1 from 3.0.
It wouldn't go to 3.0, it would be going 3.1. Unless there are significant database structure changes, the current convertor will most likely continue to work with 3.1.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Remove phpBB 2 Convertor

Post by MichaelC »

The converter will still be available, just not in the default package, similar to how subsilver 2 will be. Available but not in the main package.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply