[RFC]Quote link to quoted message

[brunoais]

Hum... There's this function:bbcode_quote() in message_parser.php...
I'll need some time to study that function and prepare it for the changes... I was thinking the changes were only in bbcode.php, actually, there's more needed for this job.
This will take a while.
Any help to speed this thing up is welcome

[imkingdavid]

For the record, afaik the BBCode system is being revamped so this could probably wait a little while until that's done.

[MichaelC]

viewtopic.php?f=84&t=33021 - New BBcode Engine for reference.

[Oyabun1]

There is code in this post, Re: In quote link back to original post, that works with the current version of phpBB (3.0.10).

[JoshyPHP]

Code: Select all

[quote="brunoais" post="15"]dsd[/quote]
[quote="brunoais" source="http://www.phpbb.com/support/irc/"]dsd[/quote]

There's no source but there's an optional url attribute as described in this post.

Shouldn't post be called post_id? It's possible to add a post_id attribute that holds a number. It's possible to have a template that uses this number in a URL, something like this:

Code: Select all

<a href="{U_VIEWPOST}{NUMBER}">{L_BACK_TO_POST}</a>

It's possible to have another optional number that holds a timestamp but there's no built-in way to generate a localized date at display time. It's possible to use the core.text_formatter_s9e_render_before event to generate a localized date and inject it in the metadata before a formatted text is displayed. Or not use an event at all and just execute the same code in the relevant context.

[brunoais]

Code: Select all

[quote="brunoais" post="15"]dsd[/quote]
[quote="brunoais" source="http://www.phpbb.com/support/irc/"]dsd[/quote]

There's no source but there's an optional url attribute as described in this post.

url can replace source (in my spec), yes.

Shouldn't post be called post_id? It's possible to add a post_id attribute that holds a number. It's possible to have a template that uses this number in a URL, something like this:

Code: Select all

<a href="{U_VIEWPOST}{NUMBER}">{L_BACK_TO_POST}</a>

L_BACK_TO_POST ? It is meant to be the link to the source post of the quote. The postId is used because the forum may change location and/or domain and, that way, it would still be working as it points to a post, not an URL.

It's possible to have another optional number that holds a timestamp but there's no built-in way to generate a localized date at display time. It's possible to use the core.text_formatter_s9e_render_before event to generate a localized date and inject it in the metadata before a formatted text is displayed. Or not use an event at all and just execute the same code in the relevant context.

I think that could be solved by calling a php function from inside the XSL. What do you think?

[JoshyPHP]

L_BACK_TO_POST ? It is meant to be the link to the source post of the quote.

Yes. L_BACK_TO_POST can be whatever string makes sense, that's just an example. U_VIEWPOST would be the static part of the URL for viewing a post, e.g. https://area51.phpbb.com/phpBB/viewtopic.php?p=. It would be set in PHP.

I think that could be solved by calling a php function from inside the XSL. What do you think?

There's no support in the library for executing arbitrary PHP while rendering a template. That's a Pandora's box I am careful not to open needlessly. That's why the simplest way to access or generate that kind of metadata is currently to inject it before rendering.

[brunoais]

Is it possible to add the preprocessing capability to your library to process variables before they are sent to the stylesheet?

[JoshyPHP]

I think that what I'm going to do is offer a utility that rewrites attribute values inside of a parsed text (which is in XML.)

Most likely it'll be used like this:

Code: Select all

$xml = s9e\TextFormatter\Utils::replaceAttributes(
    $xml,
    'QUOTE',
    function ($attributes) use ($user)
    {
        if (isset($attributes['timestamp']))
        {
            $attributes['date'] = $user->format_date($attributes['timestamp']);
        }

        return $attributes;
    }
); 

Grab all QUOTE tags, those that have a timestamp attribute get a date attribute that contains the localized date.

[brunoais]

How would quote be defined with that functionality?