Looks good to me.Arty wrote:How about this? installed styles list, uninstalled styles
[RFC] Revamp of styles section of acp
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Revamp of styles section of acp
Re: [RFC] Revamp of styles section of acp
* brunoais likes itArty wrote:How about this? installed styles list, uninstalled styles
Re: [RFC] Revamp of styles section of acp
+1Arty wrote:How about this? installed styles list, uninstalled styles
Re: [RFC] Revamp of styles section of acp
I like this changedArty wrote:How about this? installed styles list, uninstalled styles
*Imagine a signature super spectacular.*
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: [RFC] Revamp of styles section of acp
I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
Re: [RFC] Revamp of styles section of acp
A similar option is selected as the forums through a drop-down menu.DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
*Imagine a signature super spectacular.*
Re: [RFC] Revamp of styles section of acp
It's supposed to work in such way that child themes do not overlap completely their parent themes. So, if you don't want a user to be able to see a parent theme and not the child theme, then you'll have only a partial theme where things are going to be missing.DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
If you have a complete new theme, don't make it child of another theme, just point that it was made based on that theme.
Hum... nextgen has the 2nd part of my answer
Re: [RFC] Revamp of styles section of acp
It will work fine. Deactivating style only hides it from user selection, it doesn't do anything else, so template inheritance works fine regardless of style status and users can select child styles if parent has been deactivated.DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
Formerly known as CyberAlien.
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Revamp of styles section of acp
Just in case you're confusing terminology, installed != active. Yes there are requirements for parent styles to be installed before child styles are, but the parent style does not have to be active for child styles to be.DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
Re: [RFC] Revamp of styles section of acp
I've tried to redo all commits, messed up pull request while doing it, so I've closed old PR and made new one instead: https://github.com/phpbb/phpbb3/pull/577
Formerly known as CyberAlien.
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts