[RFC] Style-specific language variables

[Vinny]

To be simple, I think the file should be in: styles/prosilver/theme/{LANG_ISO}/. Example:

• styles/prosilver/theme/en/en.php for english
• styles/prosilver/theme/es/es.php for spanish
• styles/prosilver/theme/pt_br/pt_br.php for portuguese
• ...

The language imageset are already located in this directory.

Each file must have the directory name of the language, like translating a MOD.

[A_Jelly_Doughnut]

To be simple, I think the file should be in: styles/prosilver/theme/{LANG_ISO}/.

What's more simple about this than what David proposed? Particularly with the duplication (it seems that you can never have more than one file in the style/style_name/theme/lang_iso/ directory?

[Arty]

Great idea, but I propose a slightly different structure (similar to second method in david's post + fallback):

• styles/prosilver/lang/en.php
• styles/prosilver/lang/de.php
• styles/prosilver/lang/default.php

Why only one directory?

Few suggestions here put files in sub directories. There is only 1 file per language pack, no need to make multiple directories.

Why not store it with theme?

I think mixing php files with images and css is a bad idea. Nether template nor theme should not have any php files.

What is "default.php"?

Its a fallback php file that includes default (English) language pack. When including style specific language pack, if directory styles/{style}/lang exists, but there is no php file for current language pack, phpBB should include default.php. This way if style doesn't have language pack for current language, style will still work properly.

[callumacrae]

Why not just default to English?

[Ger]

What is "default.php"?

Its a fallback php file that includes default (English) language pack. When including style specific language pack, if directory styles/{style}/lang exists, but there is no php file for current language pack, phpBB should include default.php. This way if style doesn't have language pack for current language, style will still work properly.

Even better: always load default.php and also load lang_iso.php when it exists. That way, even when there are records in default.php that are omitted in lang_iso.php (due to an update for example), there'll always be something readeble instead of something like {TL_NEW_LANG_VAR}.

[Arty]

Why not just default to English?

Some styles don't have English language pack, for example, some styles released on French phpBB website. With "default" main language pack could be French with English pack in en.php

[callumacrae]

Wouldn't it be better to have a file specifying the default, instead of having a duplicate file?

[Arty]

Good point.

After thinking more about it, maybe just defaulting to en.php would be a better idea. All styles on phpbb.com required to have English language pack, so if style will include custom text it will have en.php. So never mind my suggestion, I think David's second suggestion is the way to go.

[MichaelC]

Maybe have the default language with a default suffix or default prefix?

[imkingdavid]

Ticket

I have done some initial work on this, but if someone else is already working on this or wishes to do so, feel free to.

UPDATE: Actually, this turned out to be an easy feature. Pull Request