[RFC] Remove unnecessary permissions

[Oleg]

How about this one:

acl_u_pm_emailpm Can e-mail private messages

It does not look like it's even used anywhere.

[imkingdavid]

How about this one:

acl_u_pm_emailpm Can e-mail private messages

It does not look like it's even used anywhere.

You're right. It's only in 3 files:

• develop/add_permissions.php
• install/schemas/schema_data.sql
• language/en/acp/permissions_phpbb.php

It isn't actually being used, and could be removed without consequence, afaik.

[imkingdavid]

u_chgcensors - if one runs a board for pg-13 audience one may want to prohibit everyone from seeing censored words. Also, there are boards in competitive settings where they censor their competition, in such cases admins may not want to allow users to uncensor the board.

If you want to prohibit it, disable the setting, but there's no need for a permission as well.

No, because as an administrator, I may want to see the uncensored words while prohibiting normal users from seeing them. I feel really strongly about this permission!

Fair enough, I'll leave it in. I don't feel all too strongly about removing it, I just personally didn't see a purpose for it. But if other people actually find a use for it, then it shouldn't be removed.

[Oleg]

There is a ticket for the email pm permission: http://tracker.phpbb.com/browse/PHPBB3-9568

[imkingdavid]

There is a ticket for the email pm permission: http://tracker.phpbb.com/browse/PHPBB3-9568

Well I just removed it in my patch, but I can add it back if we're planning on adding the feature. Is that the plan?

[Oleg]

Do you know where one forwards pm to email in the ui?

[imkingdavid]

Do you know where one forwards pm to email in the ui?

It is currently not implemented, afaik. Which is why it has been removed.

[Oleg]

http://tracker.phpbb.com/browse/PHPBB3- ... ment-33890 suggests that the functionality to forward pm to email exists, and is just not checked against permissions. Or am I misunderstanding this?

[imkingdavid]

http://tracker.phpbb.com/browse/PHPBB3- ... ment-33890 suggests that the functionality to forward pm to email exists, and is just not checked against permissions. Or am I misunderstanding this?

If it was there it would be similar to the Email friend functionality on viewtopic, which is an envelope icon next to the print icon above the Logout link. However, only the print icon shows there. I'm not sure if the page is there but just not linked to or if the entire page does not exist.

[imkingdavid]

For the record, all suggested permissions except u_chgcensors has been removed. If anyone thinks any others are unnecessary or if you think one that was removed is necessary (or was not removed properly), let me know and I'll see about fixing it.