Move Sid inside the ACP urls at the very end.

[callumacrae]

+1 to OP

This could give me a chance to have a go at making a patch for this.

Go for it!

[Dragosvr92]

So... Did anyone messed with it?
Is it worth submitting a ticket?

[imkingdavid]

So... Did anyone messed with it?
Is it worth submitting a ticket?

Any feature change/addition needs a ticket before it is merged, iirc.

[callumacrae]

So... Did anyone messed with it?
Is it worth submitting a ticket?

Any feature change/addition needs a ticket before it is merged, iirc.

This would be an improvement, but yeah it needs a ticket.

In the future, threads for minor issues like this don't need to be made - just create a ticket.

[Dragosvr92]

So... Did anyone messed with it?
Is it worth submitting a ticket?

Any feature change/addition needs a ticket before it is merged, iirc.

This would be an improvement, but yeah it needs a ticket.

In the future, threads for minor issues like this don't need to be made - just create a ticket.

I said not to fill the tracker with trash.
http://tracker.phpbb.com/browse/PHPBB3-10516

[Danielx64]

I'm working on it now, my issue, I don't have a git account or the guts to get all that going, can I just provide info on what edit needs to be done?

Ok I got it sorted out:

the new url look something like this:
http://localhost/phpbb3/adm/index.php?u=2&i=users&mode=overview&sid=5e22f5132839097c0e722c37eb57b4f0

What do you think?

[Oleg]

You don't technically need a github account, but manual edit instructions require too much developer effort to use. We ask that you at least provide changes as a diff.

If you have git but not a github account you can use git format-patch to obtain one or a series of diffs from develop/develop-olympus, and attach those to the ticket.

If you don't even have git but have diff you can store a copy of the tree you start with and obtain a diff between trees via:

diff -urN old.tree new.tree

I believe we also still provide a subversion mirror here: http://code.phpbb.com/projects/phpbb/repository. If you have subversion installed you can use it to check out the current develop (http://code.phpbb.com/projects/phpbb/re ... show/trunk) or develop-olympus (http://code.phpbb.com/projects/phpbb/re ... hpBB-3_0_0) and use svn to obtain a diff with your changes.

[Danielx64]

You don't technically need a github account, but manual edit instructions require too much developer effort to use. We ask that you at least provide changes as a diff.

If you have git but not a github account you can use git format-patch to obtain one or a series of diffs from develop/develop-olympus, and attach those to the ticket.

If you don't even have git but have diff you can store a copy of the tree you start with and obtain a diff between trees via:

diff -urN old.tree new.tree

I believe we also still provide a subversion mirror here: http://code.phpbb.com/projects/phpbb/repository. If you have subversion installed you can use it to check out the current develop (http://code.phpbb.com/projects/phpbb/re ... show/trunk) or develop-olympus (http://code.phpbb.com/projects/phpbb/re ... hpBB-3_0_0) and use svn to obtain a diff with your changes.

Thankyou for the info I'm think I got most of the url covered but there are several that I can't find, including one that has mode=sig in the URL.

[Danielx64]

About time, I managed to make a patch that cover some of the sid= part, there are several places that I can not figure out. I hope the patch I provide is of some help. Should I make a new ticket to have the userid the first thing when needed?