Move Sid inside the ACP urls at the very end.

[Dragosvr92]

Currently when you go to view a member into the admin control panel it generates the fallowing link:

Code: Select all

http://www.example.com/forums/adm/index.php?i=users&mode=overview&sid=ac87f64eb07f78892d66693753a908bc&u=1090

It would be nice if the sid could get moved at the end, like this:

Code: Select all

http://www.example.com/forums/adm/index.php?i=users&mode=overview&u=1090&sid=ac87f64eb07f78892d66693753a908bc

I am asking this because i usually need to know what the member id is, as i want to know what the id im going to delete etc is.
If i am not mistaken thesid is always added at the end of the url on the board. So in my opinion thats how it should be added into the ACP also.

Do you think i should put this into a ticket?

[Dr. Deejay]

I actually don't see anything wrong with the current format tbh. In my opinion it's not worth changing it.

[callumacrae]

+1 to OP

[igorw]

I'm not against merging such a patch if someone provides one.

[Dragosvr92]

I actually don't see anything wrong with the current format tbh. In my opinion it's not worth changing it.

Well i do. You should see more relevant data on the link. Not a useless sid. No one cares to know whats the sid number. But there are some that might care more if the member id is more easy to see, without getting over the dumb sid.

As on the board it gets displayed at the very end of the url, why should it be different in the ACP?

@Igor, thanks for agreeing with me, i would do it, but this is over my limits.

[DavidIQ]

It would just be a matter of updating the append_sid function. Shouldnt be that difficult I think (famous last words...).

[Dragosvr92]

It would just be a matter of updating the append_sid function. Shouldnt be that difficult I think (famous last words...).

Do i hear a second yes?

[callumacrae]

I can have a look at this while I'm on my way home (~ an hour away), I'll have nothing better to do xD

[naderman]

It would just be a matter of updating the append_sid function. Shouldnt be that difficult I think (famous last words...).

Unfortunately frequently enough stuff is appended to the return value of append_sid, so all those calls to append_sid would need to be changed.

[Danielx64]

+1 to OP

This could give me a chance to have a go at making a patch for this.