Great. That's even better.
Small note: can you change "edit" to "Edit" and "quote" to "Quote" and remove <strong> for these two buttons for consistency with other text variables: Information, Profile, PM, Website and instant messenger buttons? Also "Report" button is missing. These are small buttons inside posts, they shouldn't be treated same way as big buttons outside of posts. Lower case and bold for them should be applied via css instead of being hard coded to language file.
New template variables
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Re: New template variables
Formerly known as CyberAlien.
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: New template variables
Arty: as we also think this is a great addition for MODs as you can use the class no-icon to create a button without the icon and use normal text then, the strong markup should be in the language, or inside the button itself.
This is exactly the issue that I ment
Maybe we should add those variables twice or just change the design for prosilver (all text bold and using a space, instead of separating one word from another by using bold for one).
@nextgengt: yes, mostly like that, but without css3, so it still works on IE6-9 almost correctly
This is exactly the issue that I ment
@nextgengt: yes, mostly like that, but without css3, so it still works on IE6-9 almost correctly
Member of the Development-Team — No Support via PM
Re: New template variables
No need to change design, <strong> works great for big buttons.
However, it doesn't belong to small buttons: quote and edit. They have completely different layout and they are separate from other buttons you've added <strong> to: they are small buttons specific to post, but other buttons are for whole thread.
Those two buttons are small, using upper case text. Whole text is bold, not just part of it, it is specific to style. Using <strong> for those two buttons is hard coding style specific css to language pack. There are many other buttons with same layout (Report *missing*, Information, Dost details, Website, PM, ICQ, etc..), so if you'd prefer to hard code <strong> into those language variables, you'll have to make copies for each of them. Or use css to apply bold and upper case for only 2 buttons without duplicating language variables.
However, it doesn't belong to small buttons: quote and edit. They have completely different layout and they are separate from other buttons you've added <strong> to: they are small buttons specific to post, but other buttons are for whole thread.
Those two buttons are small, using upper case text. Whole text is bold, not just part of it, it is specific to style. Using <strong> for those two buttons is hard coding style specific css to language pack. There are many other buttons with same layout (Report *missing*, Information, Dost details, Website, PM, ICQ, etc..), so if you'd prefer to hard code <strong> into those language variables, you'll have to make copies for each of them. Or use css to apply bold and upper case for only 2 buttons without duplicating language variables.
Formerly known as CyberAlien.
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts