The styleswitcher is, in my opinion, quite a useless invention. Adjusting font sizes can be done by the browser.
Removing the styleswitcher has been discussed several times before, in the prosilver modernisation and jquery topics, but also on IRC. It would make sense to discuss this issue separately and make it official.
I'd like to get rid of the styleswitcher.
Ticket: http://tracker.phpbb.com/browse/PHPBB3-10260
Patch: https://github.com/phpbb/phpbb3/pull/271
If this gets accepted, I'll create a ticket and make a proper patch with properly formatted commit message. EDIT: done.
[RFC|Merged] Remove prosilver styleswitcher
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: [RFC] Remove prosilver styleswitcher
+1naderman wrote:Agree entirely.
Re: [RFC] Remove prosilver styleswitcher
Agree ++;
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.
Re: [RFC] Remove prosilver styleswitcher
Agree.
Good idea.
Good idea.
Re: [RFC] Remove prosilver styleswitcher
+1 from me too
I'm not sure if anyone even use it anyways. I know that some styles remove the that font resize button anyways.
I'm not sure if anyone even use it anyways. I know that some styles remove the that font resize button anyways.
Re: [RFC] Remove prosilver styleswitcher
Will proSilver use relative font sizes instead of pixels by default? Currently, everything is relative to 10px, so the only way to "resize" fonts is through the styleswitcher or using zoom.igorw wrote:Adjusting font sizes can be done by the browser.
$ git commit -m "YOLO"
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC] Remove prosilver styleswitcher
The 10px is only for setting the default, so all browsers display the same size. Apart from that prosilver only uses relative./a3 wrote:Will proSilver use relative font sizes instead of pixels by default? Currently, everything is relative to 10px, so the only way to "resize" fonts is through the styleswitcher or using zoom.
Member of the Development-Team — No Support via PM
Re: [RFC] Remove prosilver styleswitcher
I think that the image
prosilver/theme/images/icon_fontsize.gif
should also be removed, I looked at the patch and it wasn't removed.