[RFC|Merged] Delete "Confirm e-mail address"

[Oleg]

Could not test registration due to http://tracker.phpbb.com/browse/PHPBB3-10477.

There are two other locations where we ask for email confirmation. One is installer, and for that I have https://github.com/p/phpbb3/commit/1469 ... c2944e21d3 (untested).

The other one is acp, and I think it's safe to remove email confirmation there. Browsers only autocomplete email addresses when the input field is empty, and we cannot ever have it empty, can we?

[MichaelC]

What about edit account settings in UCP?

[imkingdavid]

What about edit account settings in UCP?

The pull request is ready and has deleted the field from both the registration form and the profile registration details form.

Same thing.

EDIT: I have also removed it from acp_users. Oleg, is it okay if I implement your commit into my patch?

[Oleg]

Yes, I was hoping you'd say that (you'll need to fix the commit message).

[Oleg]

Not sure what you did with my commit but you could have cherry-picked it and then amended it to rewrite the commit message:

git cherry-pick <sha1>
git commit --amend

[imkingdavid]

Not sure what you did with my commit but you could have cherry-picked it and then amended it to rewrite the commit message:

git cherry-pick <sha1>
git commit --amend

I just did it the "hard" way by performing all the actions myself. I didn't know about that method, but I'll keep that in mind for future reference.

[Oleg]

And I just found out we already have a ticket to change email addresses on unactivated user accounts:

http://tracker.phpbb.com/browse/PHPBB3-9894

[imkingdavid]

And I just found out we already have a ticket to change email addresses on unactivated user accounts:

http://tracker.phpbb.com/browse/PHPBB3-9894

Well then there's really no reason not to do this patch if that is going to be implemented as well.

[naderman]

Indeed I think that would be the proper solution, so let's merge this one.

As for the commit, it's also better to cherry-pick commits, simply because we want to keep track of who wrote what originally, and Oleg will not show up as the author of that commit now. You can change the author of the latest commit by running git commit --amend --author "A Name <[email protected]>".

[imkingdavid]

Indeed I think that would be the proper solution, so let's merge this one.

As for the commit, it's also better to cherry-pick commits, simply because we want to keep track of who wrote what originally, and Oleg will not show up as the author of that commit now. You can change the author of the latest commit by running git commit --amend --author "A Name <[email protected]>".

All done, I also changed the commit message to his original one and prepended it with the proper branch name.