Some of the tickets have status unreviewed for months....I have seen ones that have that since April (e.g. http://tracker.phpbb.com/browse/PHPBB3-9622)....how does that work?Oleg wrote:Patch in progress:
- Avatar improvements, Gravatar RFC Ticket
Status: v1 rejected - waiting for v2 from ckwalsh with better factoring- SQLite 3.0+ Support RFC Ticket
Status: patch attached to RFC topic, needs to be turned into a proper git branch; some discussion going on in RFC topic pertaining to the patch- Updated BBcode engine RFC Ticket
Status: partial implementation - discussion is in RFC topic - implementation needs to be finished- Switch to PHP timezone handling RFC Ticket
Status: partial patch in RFC topic - needs to be finished- General Hook Architecture RFC Ticket
Status: incomplete patch exists - stalled? - I am working on an alternative implementation- Improve User Pruning feature RFC Ticket
Status: unreviewed patch on github - linked to ticket- Cleaning up the ACP UI RFC Ticket
Status: unmerged patch in tracker - needs to be reviewed and merged- HipHop for PHP compatibility RFC Ticket
Status: patch submitted - some comments in the RFC topic- No db storage of themes and stylesheets RFC Ticket
Status: some work done, but incomplete
3.1 Status
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.
If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
- sooskriszta
- Registered User
- Posts: 85
- Joined: Wed Dec 29, 2010 7:23 pm
Re: 3.1 Status
OC2PS
Testfestés, Arcfestés, Csillámfestés
Alapanyagok, Képzések, Ismertetők
Hennafestés
GMAT coaching and MBA Admissions Consulting
formerly known as sooskriszta
Testfestés, Arcfestés, Csillámfestés
Alapanyagok, Képzések, Ismertetők
Hennafestés
GMAT coaching and MBA Admissions Consulting
formerly known as sooskriszta
Re: 3.1 Status
Actually, that would be a "Patch in progress"sooskriszta wrote:perhaps you should add viewtopic.php?f=84&t=41673 to the RFC only list?
Has an irascible disposition.
- sooskriszta
- Registered User
- Posts: 85
- Joined: Wed Dec 29, 2010 7:23 pm
Re: 3.1 Status
Can you share the ticket URL?
OC2PS
Testfestés, Arcfestés, Csillámfestés
Alapanyagok, Képzések, Ismertetők
Hennafestés
GMAT coaching and MBA Admissions Consulting
formerly known as sooskriszta
Testfestés, Arcfestés, Csillámfestés
Alapanyagok, Képzések, Ismertetők
Hennafestés
GMAT coaching and MBA Admissions Consulting
formerly known as sooskriszta
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: 3.1 Status
It's in the ticket https://github.com/phpbb/phpbb3/pull/389sooskriszta wrote:Can you share the ticket URL?
Re: 3.1 Status
When a developer uses "unreviewed patch" instead of "unmerged fix" for the status, they usually indicate that the work is incomplete or they want to solicit comments from other developers, essentially a request for review.sooskriszta wrote: Some of the tickets have status unreviewed for months....I have seen ones that have that since April (e.g. http://tracker.phpbb.com/browse/PHPBB3-9622)....how does that work?
In the case of the ticket you mentioned, I did actually perform a review of original patch, mode some changes and submitted a revised version. I left it as an unreviewed patch because it still was missing tests and there were some further enhancements being discussed in the RFC topic. If another developer considers the patch as it is sufficiently complete and of sufficient quality, they are free to merge that patch.
Re: 3.1 Status
Please use the new topic: viewtopic.php?f=81&t=41977