Prosilver Overhaul/Modernization

[Oyabun1]

I don't have a problem with using jQuery, I just wasn't aware of why it had been chosen. Reading through this topic it just seemed that jQuery had been mandated before analysis of what was required in a library had been done, but from the link in hanakin's Post I see that it was the developers' decision.

Including it by default should solve problems with multiple MODs all trying to load the jQuery library.

[milleja46]

Ok i've been paying attention to this topic for awhile(as a guest unregistered), and don't understand the point made about it breaking old browsers. I've seen several points made around the web where if you use modrnizr or html5siv js in pages it should enable those elements in some way....

But the rest of it sounds great, personally I use prosilver for the base of my theme for my forum and I'm glad it's at least getting started. Though I've started to somewhat put html5 into my theme since I'm using bootstrap in the theme as well(though I've moved things around to fit my main sites theme leaving much intact) though it's not done anyways. But I hope html5 is able to be used since it would help with some theme organization...

[sajaki]

hi,

Will border-radius be used for rounded corners in prosilver 3.1 ?

Or will you keep this old construct ?

Code: Select all

<span class="corners-top"><span></span></span>
<span class="corners-bottom"><span></span></span>

and the old css :

Code: Select all

span.corners-top {
	background-image: url("{T_THEME_PATH}/images/corners_left.png");
}

span.corners-top span {
	background-image: url("{T_THEME_PATH}/images/corners_right.png");
}

span.corners-bottom {
	background-image: url("{T_THEME_PATH}/images/corners_left.png");
}

span.corners-bottom span {
	background-image: url("{T_THEME_PATH}/images/corners_right.png");
}

[Oleg]

Coming to this discussion late, but just wondering why jQquery was chosen as the JavaScript framework to be used? jQuery is certainly popular at the moment, but is it the most efficient and compact and does it do everything required?

jquery was chosen because it was (and continues to be) overwhelmingly the most popular library to "traverse HTML documents, handle events, perform animations, and add AJAX" (straight from their site).

Any deficiencies it may have in objective characterizations are easily outweighed by its popularity. Think mysql.

https://area51.phpbb.com/phpBB/viewtopi ... ude+jquery
viewtopic.php?f=108&t=33747

Specifically: viewtopic.php?p=223335#p223335 onward.

[Oleg]

Will border-radius be used for rounded corners in prosilver 3.1 ?

You can check current develop branch for what is currently in 3.1. Then if there is no RFC/ticket for this change it won't happen until said RFC and/or ticket are created.

You may want to consider starting a new topic.

[imkingdavid]

As far as I am aware, using border radius instead of the old rounded images has already been merged, but I haven't checked.