sql_build_query change proposal

[sajaki]

Concerning http://wiki.phpbb.com/display/DEV/Dbal.sql+build+query, i'd like to propose a change.

the 'FROM' key array should be structured inversely of what it is now.
so instead of :

Code: Select all

 'FROM'      => array(  
        BOOKMARKS_TABLE => 'b',  
        TOPICS_TABLE    => 't' 
   ),  

you write this :

Code: Select all

 'FROM'      => array(  
         'b' => BOOKMARKS_TABLE ,  
        't'  => TOPICS_TABLE   
   ),  

advantage : you can use a table multiple times in your select. this is necessary when writing a self-join query.
also, it adheres more to the "key-value" concept.

i stumbled on this problem while working on my mod here :
http://www.phpbb.com/community/viewtopi ... #p12861299

[igorw]

While you are technically absolutely correct, I do not think it's wise to change/break APIs in this way. Extending the API may be an option, but you need to come up with a good solution ('FROM2' is it not). In your case I would simply suggest writing the query as plain SQL.

[ToonArmy]

As a crude hack you could probably do

Code: Select all

'FROM' => array(
TOPICS_TABLE => 't1',
TOPICS_TABLE . ' ' => 't2',
)
 

[sajaki]

As a crude hack you could probably do

Code: Select all

'FROM' => array(
TOPICS_TABLE => 't1',
TOPICS_TABLE . ' ' => 't2',
)
 

if you debug that, the resulting sql will only have the second table in it, i.e. t2, and any selected value referring to t1 will cause an sql error.