[RFC|Accepted] Updated BBcode engine
- callumacrae
- Former Team Member
- Posts: 1046
- Joined: Tue Apr 27, 2010 9:37 am
- Location: England
- Contact:
Re: [RFC|Accepted] Updated BBcode engine
They're not advantages, they're just differences.
Re: [RFC|Accepted] Updated BBcode engine
More flexibility is an advantage, per-se.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC|Accepted] Updated BBcode engine
Why would extensibility, speed, and intelligent/correct parsing of tags not be important?callumacrae wrote:I don't see how any of them are importantbrunoais wrote:Why mine is better:
- Mine supports parameterized BBcodes. It is already prepared to allow a quote tag like this. jBBCode supports only as much as phpBB currently supports. A single parameter or no parameter.
- Mine is faster even if I'm not using it in it's most optimized way.
- Mine is prepared for stuff like (the extra spaces are for this forum not to parse it):
[ name=abc]def]ghi[/ name]
You just need to use the other option of making it:[ name="abc]def"]ghi[/ name]
you can also use[ name="\"abc\"]def"]ghi[/ name]
without any problems (it creates <tagname att="\"abc\"]def">ghi</tagname> . With jBBCode with this[ name=abc]def]ghi[/ name]
you are stuck to <tagname att="abc">def]ghi</tagname>
Re: [RFC|Accepted] Updated BBcode engine
Meanwhile, I already found another bug that exists in nbbc, jbbcode and in this BBCode parser (it was already known that existed in this parser, anyway). Which is this:
- This text should not exist.
- This text can exist
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC|Accepted] Updated BBcode engine
Actually, I have used that as a way to indent, and I'm sure others have done likewise. IMO it should remain for consistency; otherwise people could "lose" parts of their posts.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC|Accepted] Updated BBcode engine
That could only happen if they upgrade and someone edits the post after the upgrade.
Allowing hacks to format text because of a bug in the parser that existed shouldn't be allowed IMO.
Allowing hacks to format text because of a bug in the parser that existed shouldn't be allowed IMO.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC|Accepted] Updated BBcode engine
Well, we should at least prep the Support team for support requests about parts of a post not being displayed anymore.EXreaction wrote:That could only happen if they upgrade and someone edits the post after the upgrade.
Allowing hacks to format text because of a bug in the parser that existed shouldn't be allowed IMO.
Re: [RFC|Accepted] Updated BBcode engine
By the way, are there any existing tests for the current engine? All I see is one test in
tests/bbcode/parser_test.php
and a few cases in tests/bbcode/url_bbcode_test.php
. I've looked into master and develop.- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC|Accepted] Updated BBcode engine
What you see is what you get; at the moment, that's all I'm aware of.JoshyPHP wrote:By the way, are there any existing tests for the current engine? All I see is one test intests/bbcode/parser_test.php
and a few cases intests/bbcode/url_bbcode_test.php
. I've looked into master and develop.
Re: [RFC|Accepted] Updated BBcode engine
Ok, thanks. It would be nice if someone was able to compile a list of desirable characteristics, if not specs, for the current engine or future solution. It would be even better to sort them out as "essentials" (e.g. "needs to allow custom BBCodes"), "nice-to-haves", and perhaps even features that could be phased out such as per-style custom BBCode templates.
Perhaps the fine people over at the 3.0.x Support Forum could chime in with the most common grievance about phpBB's BBCodes, or about the whole text formatting for that matter? MOD authors such as the authors of Advanced BBCode Box 3 may have some valuable input as well.
Perhaps the fine people over at the 3.0.x Support Forum could chime in with the most common grievance about phpBB's BBCodes, or about the whole text formatting for that matter? MOD authors such as the authors of Advanced BBCode Box 3 may have some valuable input as well.