[RFC|Merged] Switch to PHP timezone handling
- AmigoJack
- Registered User
- Posts: 110
- Joined: Wed May 04, 2011 7:47 pm
- Location: グリーン ヒル ゾーン
- Contact:
Re: [RFC|Accepted] Switch to PHP timezone handling
It's not that we need to actually pre-select the right time zone - the whole list could be filtered, so only time zones show up which are +/- 2 or 3 hours of the current local time. Because there is no rule that daylight saving is always 1 hour delta.
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC|Accepted] Switch to PHP timezone handling
Oleg can you rebase this on develop, there are some strange conflicts in install/database_update.php with your last commit.
Member of the Development-Team — No Support via PM
Re: [RFC|Accepted] Switch to PHP timezone handling
I got as far as plurals for now.
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC|Accepted] Switch to PHP timezone handling
I updated the branch of oleg to develop and worked a bit on it:
https://github.com/nickvergessen/phpbb3 ... z-handling
The selection is now made in 2 steps:
1. Select your current time (limits the number of timezones in step 2)
2. Select the actual timezone Without Javascript, we can not do much, but give the hole list:
https://github.com/nickvergessen/phpbb3 ... z-handling
The selection is now made in 2 steps:
1. Select your current time (limits the number of timezones in step 2)
2. Select the actual timezone Without Javascript, we can not do much, but give the hole list:
Member of the Development-Team — No Support via PM
Re: [RFC|Accepted] Switch to PHP timezone handling
I like, I think.
Re: [RFC|Accepted] Switch to PHP timezone handling
Please make sure, the feature PR includes a functional test.
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC|Accepted] Switch to PHP timezone handling
Todo:
- Change selection in ACP
- Change selection in subsilver2
- Add function to calculate the unix timestamp of a given user date and time
- Add code to update
- Write tests
Member of the Development-Team — No Support via PM
Re: [RFC|Accepted] Switch to PHP timezone handling
From what I recall language had to be changed to use 3.1 plurals and migrations/install code needed to be written.
- nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
- Contact:
Re: [RFC|Accepted] Switch to PHP timezone handling
I would not know, where plurals are used, but I will review it. thanks for rementioning.
Member of the Development-Team — No Support via PM