Git hooks
Re: Git hooks
Better validation: http://github.com/cs278/phpbb3/compare/ ... ;git-tools
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: Git hooks
Merged into develop-olympus.ToonArmy wrote:Better validation: http://github.com/cs278/phpbb3/compare/ ... ;git-tools
Re: Git hooks
Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: Git hooks
Good idea. Created ticket http://tracker.phpbb.com/browse/PHPBB3-9777nn- wrote:Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools
Re: Git hooks
FYI It's been merged and just needs verifying.bantu wrote:Good idea. Created ticket http://tracker.phpbb.com/browse/PHPBB3-9777nn- wrote:Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools
- bantu
- 3.0 Release Manager
- Posts: 557
- Joined: Thu Sep 07, 2006 11:22 am
- Location: Karlsruhe, Germany
- Contact:
Re: Git hooks
When using "git revert" the prepared revert commit message should contain the ticket ids (e.g. PHPBB3-1234) of the commits that are being reverted. Is that possible?
Re: Git hooks
I'm having some issues. The `wc` that ships with OS X does not support --max-line-length or --lines.
Maybe add a check for OS X in which case to disable that feature? Not sure what's the best way to check that though.
Maybe add a check for OS X in which case to disable that feature? Not sure what's the best way to check that though.
Re: Git hooks
wc -l is specified in posix (http://www.opengroup.org/onlinepubs/000 ... es/wc.html), use it instead of --lines.
Max line length sounds like it could be replaced with cut.
Max line length sounds like it could be replaced with cut.
Re: Git hooks
How would one go about that with cut?nn- wrote:wc -l is specified in posix (http://www.opengroup.org/onlinepubs/000 ... es/wc.html), use it instead of --lines.
Max line length sounds like it could be replaced with cut.
Re: Git hooks
Can we have that section commented out until a cross-platform solution is found? I'd really like to re-enable my git plugins.