Group Avatar = User Avatar?

[matthewf]

I tested a recent CVS, I was a little wrong with avatar handing,

a user has a avatar, he is made default to a group that has no avatar, = he keeps his avatar, even though he loses his rank, (if he had one)

a user has a avatar, he is made a default to a group that has a new type of avatar, = his avatar is replaced with the new group one

of course the second one only applies to if he was made default to the group, if he isn't then he keeps his rank and avatar

[jojobarjo32]

Mhh... Indeed (I just tested in the last CVS and you're right)

Perhaps I'm wrong but I believe this is a bug since the documentation clearly stated that this is group's rank & avatar which is overriden by users' specific ones. Moreover, this is more logic "my way" I think... I report this in the bug tracker.

[matthewf]

that behavior is correct as it states at the bottom

If you make a group the default one that has a rank and avatar set, the user's old avatar and rank will be overwritten by the group

there for its not a bug, but intended

[jojobarjo32]

This behavior is not very logic for me
A user who has an avatar doesn't want to lose it if he joins a group (and make it its default group).
The "normal" behavior is (in my opinion) :

Code: Select all

if user has an avatar
	then use user's avatar
else if user's default group has an avatar
	then use group's avatar

[matthewf]

making a user default to a group I think has no real advantages then not making default to a group, (I could be wrong?) so if a user wants to keep his avatar and rank, then he could join the group but not made default to it, or change it back, if he was made default to the group,

[Highway of Life]

This behavior is not very logic for me
A user who has an avatar doesn't want to lose it if he joins a group (and make it its default group).
The "normal" behavior is (in my opinion) :

Code: Select all

if user has an avatar
	then use user's avatar
else if user's default group has an avatar
	then use group's avatar

I agree with you here, but unfortunately, that would mean adding a feature...
Possibly I should submit a DIFF on this to the Dev's and see what they think.
Basically, I think it should be a group option to "overwrite users with existing avatars/ranks" or not.
It is something that has bugged me since before Beta1.

[jojobarjo32]

I thought to send a similar patch to the devs too but Meik has said this is the intented behavior.
In any cases, I think this behavior will cause some troubles with users.

[Highway of Life]

I thought to send a similar patch to the devs too but Meik has said this is the intented behavior.
In any cases, I think this behavior will cause some troubles with users.

Yes, I'm quite aware that it's the intended behavior, and that's fine, but it could and does cause some problems, especially if the admin does not realize that it's going to overwrite the avatar.
And same for the user if he sets his default group.
Can't hurt to submit a patch... even if he rejects it, at least I can say I tried.

[matthewf]

This behavior is not very logic for me
A user who has an avatar doesn't want to lose it if he joins a group (and make it its default group).
The "normal" behavior is (in my opinion) :

Code: Select all

if user has an avatar
	then use user's avatar
else if user's default group has an avatar
	then use group's avatar

I agree with you here, but unfortunately, that would mean adding a feature...
Possibly I should submit a DIFF on this to the Dev's and see what they think.
Basically, I think it should be a group option to "overwrite users with existing avatars/ranks" or not.
It is something that has bugged me since before Beta1.

but is there any point in making a user default to a group? as that is when this only happens, the only thing that as far as I can see changes, is the username colour, if I add a group (so that they can access it) to a forum, and add users that aren't default to that group, they can see that forum, with or without been default to that group, so as far as I can there is no extra benefits either way, so technically the above issue about losing avatars shouldn't be a problem, unless a bright spark tells me otherwise?

[jojobarjo32]

Apart from the user color (and IIRC, the users listed as administrators on the "Team" page are only those who have the Administrators group as their default one), it's true there is no benefit.