IN-LINE REMOVE

[Wicher]

Hello, i was looking at the mod actions that are available.
I am missing one:

IN-LINE REMOVE

I think this could be a very handy action to use here and there.

For example:

Code: Select all

# 
#-----[ FIND ]------------------------------------------ 
# 
		<td colspan="7" class="row2"><input class="post" type="text" name="{catrow.S_ADD_FORUM_NAME}" /> <input type="submit" class="liteoption"  name="{catrow.S_ADD_FORUM_SUBMIT}" value="{L_CREATE_FORUM}" /></td>
# 
#-----[ IN-LINE REMOVE ]------------------------------------------ 
# 
class="row2"
# 
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------ 
# 
# EoM 

Greetzz Wicher.

[Nightrider]

Yes, I agree. That would be a nice addition. A simple REMOVE command would be nice too...

[Wicher]

In addition to that it would be very nice to have a "delete" command for removing files when writing a update_MOD.txt for any kind of mod.
At this date in time there is only the copy command.

[Nightrider]

It would also be nice to include backups of files overwritten by included files provided by the MOD author. There are several MODs where the MOD author overwrites standard phpBB files with his own versions. So if you decide that you don't like the MOD but failed to create a backup of the overwritten file before installing the MOD, you are screwed...

EM only creates backups of files that it modifies. If the MOD author is dumb enough to overwrite standard phpBB files with his own, EM is willing to allow them to do it without creating a backup that can be restored...

[Wicher]

Not making backups before installing a mod would be dumb of the installer to ofcourse.

[Nightrider]

EM creates backups of all files that it modifies, which is exactly what a person should do if they manually modify their files. The problem comes when an included MOD file overwrites an existing phpBB file. Chances are even if you manually modify your files, you might not think about making a backup of a file that you did not modify, and then you would be equally screwed if you decide to remove the MOD...

[Wicher]

So there should be a warning system when easymod has to overwrite an existing phpbb file.
Do you want to overwrite yes or no.

[Nightrider]

Yes, that would be a nice addition in a future upgrade. Still, you would want a backup of the old file just in case you decide not to keep the MOD installed on the site...

For now, you have to review the MOD to make sure that the MOD author is not overwiting standard phpBB files with his/her own. There really is never any good reason to do that, so IMO, it is sloppiness and/or laziness on the MOD author's part to use the same phpBB filename for an included MOD file. There is no good reason for a MOD author to overwrite a standard phpBB file with a copy of their own...

[Wicher]

Well, lets hope someone will read this writings here and take action on it.

[Nightrider]

I agree. This might be a good topic to keep alive and add known EM bugs and wishlist enhancements. That way wGEric can have everything he needs for creating the next version all in one topic...