[BUG REPORT] Bug in handling MOD without SAVECLOSE

[Bananeweizen]

Hi !

If a MOD has no SAVECLOSE action then EasyMOD 0.0.10a stops with saying "Installation failed" but does not show any sign of _what_ went wrong (i.e. the place where I expect the error message is just empty).

Ciao, Michael.

[GPHemsley]

Hmm.. I seem to remember this one coming up before, but I can't remember where..... Maybe it was even you that brought it up the first time?

[Bananeweizen]

Uh, oh. Maybe. Don't remember all the things I wrote in the last year.

Today I found another similar thing. I had accidentally made a MOD ending like this (with other actions pasted after SAVECLOSE but before EOM):

Code: Select all

#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#

#
#-----[ OPEN ]------------------------------------------
#

includes/functions.php

#
#-----[ FIND ]------------------------------------------
#

include($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_main.' . $phpEx);

#
#-----[ AFTER, ADD ]------------------------------------------
#

include($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_main_map.' . $phpEx);

#
#-----[ FIND ]------------------------------------------
#

include($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_admin.' . $phpEx);

#
#-----[ AFTER, ADD ]------------------------------------------
#

include($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_admin_map.' . $phpEx);

# EoM

After processing this (for a very long time) only the titlebar of the EasyMod page is shown where I normally get the results.

Ciao, Michael.

[Nuttzy99]

Moving to the bug tracker forum. I think this is legit.

EDIT: hrmmm... "moving" is broken for now so I guess it will stay right here

-Nuttzy