question about invalid upload file names

[oferlaor]

I use an iOS shortcut called "Apple frames", while it's very useful (it basically wraps screenshots with the right phone background that the screenshot was taken on), it has the peculiar behavior of changing the file name to the date. The file name is valid on iOS, but no where else (it uses the : for the time separator).

As I was trying to understand why I cant directly upload the file to phpbb, since files->common_check gives an INVALID_FILENAME error, I noticed something strange. The system actually now uses clean_filename('unique' but it still checks the common_check before that, despite it no longer being relevant as the realname later gets replaced with the hash anyway...

To test this theory I tried to see what happens if I remove this check and indeed, it all works as expected (because clean_filename('unique') runs later on anyway...

the issue is in: /phpbb/phpbb/files/upload.php

Code: Select all

/*
		// check Filename
		if (preg_match("#[\\/:*?\"<>|]#i", $file->get('realname')))
		{
			$file->error[] = $this->language->lang($this->error_prefix . 'INVALID_FILENAME', $file->get('realname'));
		}
*/

[danieltj]

If you think you've found a bug, you should add it to the tracker so it can get reviewed for a potential fix. Having said that, I've never seen a colon in a file name and didn't think it's valid. I know you can use a colon to specify a port but for files... I don't think that's allowed.

As per your code, the preg_match ((preg_match("#[\\/:*?\"<>|]#i", $file->get('realname')))) is looking for the colon and returning the error message. Perhaps the function needs tidying up a bit? Either way... raise a ticket!

[oferlaor]

yeah, the source of the issue is that the file name was generated by an iOS shortcut.