missing autocomplete for username

General discussion of development ideas and the approaches taken in the 3.x branch of phpBB. The current feature release of phpBB 3 is 3.3/Proteus.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB 3.3.x. If you need support for phpBB 3.3.x please visit the 3.3.x Support Forum on phpbb.com.

If you have questions regarding writing extensions please post in Extension Writers Discussion to receive proper guidance from our staff and community.
Post Reply
User avatar
Prosk8er
Registered User
Posts: 66
Joined: Sun Mar 11, 2007 1:19 am
Location: Rochester, Ny
Contact:

missing autocomplete for username

Post by Prosk8er »

was checking a style for any errors and noticed a browser warning for "An element doesn't have an autocomplete attribute"
A form field has an id or name attribute that the browser's autofill recognizes. However, it doesn't have an autocomplete attribute assigned. This might prevent the browser from correctly autofilling the form.
To fix this issue, provide an autocomplete attribute.
to fix it i added autocomplete="username" to the username fields for login areas
should i leave it as autocomplete="username" or switch it to autocomplete="off" like it is for the password?
i'll make a ticket for it and pull request on github pending above question

*now that i think it about it, it should probably be off cause usernames will most likely be different for multiple forums?
Last edited by Prosk8er on Wed Nov 29, 2023 1:35 pm, edited 1 time in total.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: missing autocomplete for username

Post by DavidIQ »

Should be username. Also "off" doesn't work anymore.
Image

User avatar
Prosk8er
Registered User
Posts: 66
Joined: Sun Mar 11, 2007 1:19 am
Location: Rochester, Ny
Contact:

Re: missing autocomplete for username

Post by Prosk8er »

in that case should the password one be changed from off to current-password

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: missing autocomplete for username

Post by DavidIQ »

Is that an actual autocomplete key recognized by browsers?
Image

User avatar
Prosk8er
Registered User
Posts: 66
Joined: Sun Mar 11, 2007 1:19 am
Location: Rochester, Ny
Contact:

Re: missing autocomplete for username

Post by Prosk8er »


User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1904
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: missing autocomplete for username

Post by DavidIQ »

I don't see why not then.
Image

User avatar
Prosk8er
Registered User
Posts: 66
Joined: Sun Mar 11, 2007 1:19 am
Location: Rochester, Ny
Contact:

Re: missing autocomplete for username

Post by Prosk8er »


Post Reply