html validation errors

[Prosk8er]

so got bored this morning and started running pages through the validator and found some errors/warnings for 3.3.x
memberlist_team.html
Error: Bad value for attribute action on element form: Must be non-empty.

Code: Select all

<form method="post" action="{S_MODE_ACTION}">

upon digging looks like {S_MODE_ACTION} is not set in the memberlist.php for the team case

Error: Duplicate ID team.
Warning: The first occurrence of ID team was here.

Code: Select all

<table class="table1" id="team">

because there is 2 groups in the team page it copy's the table. is the id needed?
i removed the id on localhost and didn't notice any issues or changes

https://tracker.phpbb.com/browse/PHPBB3-16814
i can do a pull request also at least for the second one if removing the id is ok

[Prosk8er]

bumping this

and also ran every html i could through the validator
and need help with the following so i can make a PR for ucp

ucp.php?i=ucp_prefs&mode=personal (styles/prosilver/template/timezone_option.html)
Error: Attribute timezone-preselect not allowed on element input at this point.

Code: Select all

		<input type="button" id="tz_select_date_suggest" class="button2" style="display: none;" timezone-preselect="<!-- IF S_TZ_PRESELECT -->true<!-- ELSE -->false<!-- ENDIF -->" data-l-suggestion="{L_TIMEZONE_DATE_SUGGESTION}" value="{L_TIMEZONE_DATE_SUGGESTION}" />

ucp.php?i=ucp_groups&mode=manage (styles/prosilver/template/ucp_groups_manage.html)
Error: Bad value for attribute action on element form: Must be non-empty.

Code: Select all

<form id="ucp" method="post" action="{S_UCP_ACTION}"{S_FORM_ENCTYPE}>

S_UCP_ACTION isn't set in includes/ucp/ucp_groups.php for the manage function

i did find some other errors/warnings that i was able to fix but want to wait till these 2 above issues are solved so i can submit 1 PR for ucp

[3Di]

The first thing that comes to my mind is how the validator can access UCP/ACP/MCP as it is not authorised.

The second thing is that if you don't know how to fix it, you could open a ticket for every single problem in the tracker and let the developers decide whether or not to intervene.

The third is that sooner or later the *CP modules will be ported to controllers, so it's probably not worth spending time on this.

This is just my conjecture though.

[Prosk8er]

i viewed source and pasted into the validator

[3Di]

Which IMHO makes no sense also as per the above points.

[Prosk8er]

ik i got bored lol i'll just fix the easy ones and leave the rest for now or open tickets

[hanakin]

if its code generated from the back-end then mark/flag it in a ticket for removal from the backend as we are going to have to factor all of that out eventually.

[david63]

removal from the backend as we are going to have to factor all of that out

Out of interest who is going to do this refactoring and go through every core .php file to find any html that may be in them? Also if this "refactoring" is done will it not break prosilver?

[hanakin]

As we work the new theme all of it will work itself out or become obsolete! As we refactor it will be ported over where possible. It all has to be done in order to build a new theme. Prosilver will only get updates to what is changed. There maybe some legacy stuff that remains untouched as it’s may not be required for the new theme. Especially as we convert things over to controllers/rework the control panels anyway.