phpBB 3.3.4-RC1 released

[P_I]

What about those few phpBB debug messages? Did you find them in your error logs or on the main screen after installation?

On the screen during the installation process, in yellowish banner. At the time I didn't check if there was anything further in the server logs. I've checked now and didn't find anything in the server error_log.

[3Di]

What about those few phpBB debug messages? Did you find them in your error logs or on the main screen after installation?

On the screen during the installation process, in yellowish banner. At the time I didn't check if there was anything further in the server logs. I've checked now and didn't find anything in the server error_log.

Yeah that's normal because the installer has a custom error handler. Thanks, I will chime on this soon.

[P_I]

I've been attempting to understand the underlying code and I'm nowhere near an expert in PHP syntax. So can someone help me understand something. There are a number of places in the code that use the syntax

Code: Select all

@define(string $name , mixed $value);

Examples are in https://github.com/phpbb/phpbb/blob/mas ... stants.php.

In the specific case of CONFIG_TABLE, take a look at https://github.com/phpbb/phpbb/blame/e1 ... s.php#L241 which seems to track back to PHPBB3-14349.

I cannot find any mention of the use of the @define in https://www.php.net/manual/en/function.define.php. Is there a reference that I'm missing? I also checked the MediaWiki and WordPress code (I use both) and cannot find any use of @define in their coding.

Or could this be something showing up as mentioned in https://www.php.net/manual/en/migration ... atible.php

A number of notices have been converted into warnings:

Attempting to read an undefined variable.
Attempting to read an undefined property.
Attempting to read an undefined array key.
Attempting to read a property of a non-object.
Attempting to access an array index of a non-array.
Attempting to convert an array to string.
Attempting to use a resource as an array key.
Attempting to use null, a boolean, or a float as a string offset.
Attempting to read an out-of-bounds string offset.
Attempting to assign an empty string to a string offset.

[3Di]

That's PHP 101: the @ operator silences potential errors, but in PHP 8 NOT fatal errors.
It`s part of error handling, better not to use it, instead face the potential issues.

FWIW, that's not really a question for this topic though.

[P_I]

Thank you for the pointer. Carry on and let me know if there is any further testing I can help with.

[3Di]

Thank you for your contribution, much appreciated. Really.
I will conduct some more tests here prior to request the PR's review, just I need one more day.

[3Di]

...
In the specific case of CONFIG_TABLE, take a look at https://github.com/phpbb/phpbb/blame/e1 ... s.php#L241 which seems to track back to PHPBB3-14349.
...

Suppress output due to duplicate definition in installer

That's what I pointed out just some posts above, in fact.

[P_I]

Again please forgive this self-described PHP non-expert, but isn't includes/constants.php the proper place to define the constant. If somewhere else is triggering a duplicate definition, shouldn't the fix be made in locally?

It seems very backward to me to handle a possible duplicate definition by coding the check in includes/constants.php.

[3Di]

Again please forgive this self-described PHP non-expert, but isn't includes/constants.php the proper place to define the constant. If somewhere else is triggering a duplicate definition, shouldn't the fix be made in locally?

It seems very backward to me to handle a possible duplicate definition by coding the check in includes/constants.php.

In the future that file should became deprecated, ATM we have to live with it.

[3Di]

the @ operator silences potential errors, but in PHP 8 NOT fatal errors.

https://www.php.net/manual/en/language. ... ontrol.php

Warning

Prior to PHP 8.0.0, the value of the severity passed to the custom error handler was always 0 if the diagnostic was suppressed. This is no longer the case as of PHP 8.0.0.